Code Monkey home page Code Monkey logo

Comments (16)

DanTup avatar DanTup commented on May 27, 2024

@devoncarew recently made a bunch of changes that I think covers this. I might push another build to the marketplace tomorrow if I get some time to finish a few more things.

Thanks for the feedback!

from dart-code.

DanTup avatar DanTup commented on May 27, 2024

See #26 for details/screenshot.

from dart-code.

jacehensley-wf avatar jacehensley-wf commented on May 27, 2024

Awesome!

from dart-code.

DanTup avatar DanTup commented on May 27, 2024

I guess this can be considered a dupe then. Do post back if after the update you think it needs more attention!

from dart-code.

jacehensley-wf avatar jacehensley-wf commented on May 27, 2024

I noticed the update to the tooltip and it is much better I would like it to keep newlines and indentation if possible.

imge

from dart-code.

DanTup avatar DanTup commented on May 27, 2024

The blank lines are being removed by Code :( I've raised microsoft/vscode#10311 to see what MS say.

The other issue seems to be a weird bug; I've posted in the Analysis Server group to try and understand what's happening.

from dart-code.

DanTup avatar DanTup commented on May 27, 2024

Microsoft have fixed the blank lines disappearing for the next version (presumably in next insiders release too, but I'm not sure how often that updates, I don't use it yet).

Still awaiting a response from the other issue; it seems like it might be a cache invalidation issue or something in the Dart analysis service so I'm hoping Google can confirm or suggest what I might be doing wrong.

from dart-code.

DanTup avatar DanTup commented on May 27, 2024

MS have fixed the newlines vanishing and Google have fixed the issues causing tooltips to sometimes show stale data. These will be in future (hopefully next) updates to VS Code and the Dart SDK :-)

from dart-code.

DanTup avatar DanTup commented on May 27, 2024

Probably makes sense to keep external issues open until they're dealt with to avoid duplicates being opened (and as a reminder there's something we want to do that is waiting on something else).

Both the issues involved here are fixed but there hasn't been a new Code or SDK release yet.

from dart-code.

DanTup avatar DanTup commented on May 27, 2024

Test this with in Insiders with 1.19 SDK, it's better, but still not right:

Tooltip

Will need to investigate again.

from dart-code.

DanTup avatar DanTup commented on May 27, 2024

I think the problem is that Code doesn't know the indented blocks are Dart.

from dart-code.

DanTup avatar DanTup commented on May 27, 2024

We can fix this by sending code blocks as MarkedStrings with the language set, or rewriting the blocks to by fenced with triple-backticks and a language.

from dart-code.

DanTup avatar DanTup commented on May 27, 2024

I think the fix for this has introduced far more spacing than intended; I think we're waiting on microsoft/vscode#10311 (comment) again for now.

from dart-code.

DanTup avatar DanTup commented on May 27, 2024

The issue in code is actually only affecting lists; the other stuff we can already fix (but we'll need to detect code blocks to mark them up as Dart).

from dart-code.

DanTup avatar DanTup commented on May 27, 2024

This is back with MS; two reasons:

  1. Insiders appears to be dropping newlines again: microsoft/vscode#10311 (comment)
  2. Request for allowing us to provide a default language for code blocks: microsoft/vscode#11331

from dart-code.

DanTup avatar DanTup commented on May 27, 2024

Considering this done now. MS intend to ship VS Code 1.5 today and 1.19 SDK is already out.

Hovers are going to get an overhaul soon (in Code, and then Dart Code) so things will improve further in a future version.

from dart-code.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.