Code Monkey home page Code Monkey logo

Comments (5)

darraghoriordan avatar darraghoriordan commented on May 31, 2024

Thanks for the report

This is just a regex if i remember correctly. Feel free to submit a PR to update the regex if you have time. I guess it needs to ignore anything not in literal string quotes

from eslint-plugin-nestjs-typed.

darraghoriordan avatar darraghoriordan commented on May 31, 2024

This is fixed in 3.22.2

the rule ignores template literals and identifiers

from eslint-plugin-nestjs-typed.

mcmxcdev avatar mcmxcdev commented on May 31, 2024

We have upgraded to the latest version but unfortunately the fix doesn't solve any of our false positives:

  @Put(`onboarding-periods/:id/${MAJOR_MEDICAL_PLAN_URL}`)
  async upsertMajorMedicalPlan(
    @Param('id') periodId: string,
  @Get(FILTERS_URL) // ":employerId/major-medical-plans/filters"
  async getMajorMedicalPlanFilters(
    @Param('employerId', new ParseUUIDPipe()) employerId: string

from eslint-plugin-nestjs-typed.

darraghoriordan avatar darraghoriordan commented on May 31, 2024

I just added both of those to the test suite and it passes as expected (they are ignored). Are you certain you're using the latest version?

I can't recreate this with the samples you provided, perhaps you can take the time to debug this one yourself?

from eslint-plugin-nestjs-typed.

mcmxcdev avatar mcmxcdev commented on May 31, 2024

You are correct, my bad, I guess I was in some half-updated state in VSCode. The warnings are gone, thank you!

from eslint-plugin-nestjs-typed.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.