Code Monkey home page Code Monkey logo

Comments (5)

darraghoriordan avatar darraghoriordan commented on May 30, 2024 1

thanks for the report, i'll look into this soon!

from eslint-plugin-nestjs-typed.

darraghoriordan avatar darraghoriordan commented on May 30, 2024

i'm trying to reproduce this but I can't. I've created a new project using nest new my-project. It creates a similar structure to above. I add the eslint plugin, class-validator to get it working. Then yarn lint - I don't get that error about files matching.

The only thing I can think of is that you're not running the lint command in the same "level" as the root level described in the program structure there? There is an overridable option for this rule to specify an alternative src directory path but i would probably just change to the dir where the project is and yarn lint in the there if i was scripting somethign for monorepo or similar.

Let me know if i'm missing some step in my reproduction 👍

from eslint-plugin-nestjs-typed.

vic1707 avatar vic1707 commented on May 30, 2024

Hello, thanks for your time.

The error message comes both from vscode itself as well as tu lint script of my nest project so I don't think I'm running it from the wrong place 🤔
The strange thing to me is that it's the only rule causing trouble so for now I have disabled it.

I'll go back and try again asap

from eslint-plugin-nestjs-typed.

darraghoriordan avatar darraghoriordan commented on May 30, 2024

hey sorry i should have described it better. And my thoughts here are just a guess, the issue could be something completely different.

========

There is a bit of code in that rule that actually scans the file system for things decorated with @Module. This is outside of the files you pass to eslint for linting (it has to be).

The default search location is src/**/*.ts. It is relative to the place that you run eslint from. If you have <projectroot>/src/.... and you run eslint from the root then you're all good.

However if you had something like <projectroot>/packages/backend/src/... and you run eslint from projectroot then the specific rule wouldn't find anything at src/**/*.ts.

The rule is configurable though. So in the case above you could have

    "@darraghor/nestjs-typed/injectable-should-be-provided": [
            "error",
            {
                src: ["packages/backend/src/**/*.ts"],
                filterFromPaths: ["node_modules", ".test.", ".spec."],
            },
        ],

Again, this is a wild guess as to what the issue is. But something is preventing the rule from finding your project module files at the relative path src/**/*

from eslint-plugin-nestjs-typed.

vic1707 avatar vic1707 commented on May 30, 2024

oh, I understand.

i should have described it better

Not necessarly, it can also be my non native english which is not that great.

Adding the override works like a charm, that's perfect !

from eslint-plugin-nestjs-typed.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.