Support for hostless URLs about go-esi HOT 7 CLOSED

You're right, it would be simpler to use only conditions and could write the fix with these conditions

• if it starts with // then add the scheme (because the golang client request need the scheme)
• else if it starts with / then add the scheme + host

from go-esi.

Hello @dkarlovi. It doesn't support the relative URLs yet but it could be supported with a check here https://github.com/darkweak/go-esi/blob/master/esi/include.go#L55.
The check could be like

// include.go
var rgStartsWithSlash = regexp.MustCompile("^/[^/].+")

//....

// L.55
if rgStartsWithSlash.MatchString(i.src) {
    // Get infos from req.URL
    i.src = req.URL.Scheme + req.URL.Host + i.src
}

from go-esi.

Wouldn't it be faster to just check the first char, without a regex?

from go-esi.

Either way, I'll try a PR with this, thanks for the pointers!

from go-esi.

No because it could be //domain.com/something that is not valid but possible URL without scheme and we shouldn't prefix with the initial request scheme + host

from go-esi.

If leading //, it doesn't need the scheme + host, else if leading / it does, maybe?

from go-esi.

#6

from go-esi.