Replace build dependency on libgnome-keyring by libsecret about seahorse-caja HOT 4 CLOSED

Ok. I'll start as soon as my work schedule allows it. Will try to do it myself, but guess l'll need help at some point if there is a deadline.

from seahorse-caja.

Seems It's done in my test machine. There are no includes for libgnome-keyring, neither major code modifications were needed. Upstream code for latest stable (as you know seahorse-caja is a fork of seahorse-nautilus) just links to libgnome-keyring, but the only relevant code used to access the keyring is through gcr library. I'm going to do some more testing and review the code (after a quick review, seems nothing is really used to justify libgnome-keyring dependency). For the time being, just replaced the libgnome-keyring dependency with libsecret, but seems does not really use it either, because it works perfectly without any code modification.

Please, do me a favor and help me testing this patch.
seahorse-caja-libsecret.zip

Tomorrow I'll do some extra testing removing libsecret and test if everything works. Recentely seahorse-nautilus migrated from autotools to meson, and current commit with meson config does not include any reference to libgnome-keyring or libsecret. So seems libgnome-keyring dependency is just a left-over form earlier development.

If things work as I expect, will release 1.18.4 this week.

from seahorse-caja.

Ok. I just did the test. libgnome-keyring is not used. It was a left-over from earlier development. So, just removed this dependecy. Code works fine. So, I'm releasing 1.18.4.

from seahorse-caja.

from seahorse-caja.