Indications are not supported. about rxandroidble HOT 12 CLOSED

The setupNotification would return an Observable that will emit BleCharacteristicNotificationOfOtherTypeAlreadySetException. (Long name...)

from rxandroidble.

Added support for the indications with commit: https://github.com/Polidea/RxAndroidBle/commit/f69ce78b18f635d23efc9b71e06c3e6e7d87d1c9.
A new release will be made after we will fix the bugs found. For the moment you can use the snapshot: compile 'com.polidea.rxandroidble:rxandroidble:1.1.0-SNAPSHOT'.

from rxandroidble.

This is true, the library does not handle indications yet. You are welcome to open a pull request :)

from rxandroidble.

How much testing do you want to see? It looks like setupNotification is heavily-tested, but much of that seems like it would be redundant to replicate.

from rxandroidble.

If you'd use same code don't duplicate tests. Just test what is new. Also I'd review the pull request itself for any bugs.

from rxandroidble.

With Paweł we will think how to handle situations where user would set a notification after setting indication to the same characteristic. Edge case - never the less needs to be addressed somehow. With your current proposal first setter would win and the second one would end up using the first one.

from rxandroidble.

@dariuszseweryn that is correct, and the reason that I haven't made a PR yet.

from rxandroidble.

What about adding an overwrite parameter to setupNoticication and setupIndication methods?

When user would want to set a notification after setting indication to the same characteristic and overwrite is false then nothing happens, otherwise a notification is set. The same would apply in other direction (setting indication after setting notification to the same characteristic).

from rxandroidble.

This is exactly what i'm needing. Your hack works great @mzgreen.

Is the overwrite parameter really needed? It seems like an overwrite could always happen and leave it up to the developer to check if a notification/indication is already set to the same characteristic.

from rxandroidble.

@cbodin Actually my idea with overwrite was wrong. It could lead to unexpected behavior. One way would be to not allow to set notification after setting indication and vice-versa. There is no perfect solution that would make it easier for developer I think.

from rxandroidble.

We will go with emitting an exception when the indication is being set after notification was already setup (or vice-versa). We are discussing the best API still though. The code should be available within this week.

from rxandroidble.

Emitting exception directly when subscribing or throwing an exception when the setupNotification method is called?

from rxandroidble.