Code Monkey home page Code Monkey logo

Comments (10)

saricden avatar saricden commented on August 28, 2024

Update:

I think I've zeroed in on the problem. It appears the .map() function is throwing it off, because instead of returning JSX elements directly as children, it returns them as an array of children, which seems to be where the bug is coming from.

Works:
works

Doesn't work:
no-works

from react-flip-page.

darenju avatar darenju commented on August 28, 2024

I have merged your PR and have published a new version of the package 1.6.3 that contains your fix.

Can you please confirm it works with this version?

Thank you!

from react-flip-page.

saricden avatar saricden commented on August 28, 2024

@darenju On it 👍

from react-flip-page.

saricden avatar saricden commented on August 28, 2024

Hey @darenju I installed version 1.6.3 via yarn add react-flip-page but it appears the node_module directory doesn't contain the dist directory, so when I boot up my app it throws:

Module not found: Can't resolve 'react-flip-page' in '...'

Is this something on your end?

from react-flip-page.

saricden avatar saricden commented on August 28, 2024

If I copy over the dist directory to node_modules/react-flip-page all is well.

from react-flip-page.

darenju avatar darenju commented on August 28, 2024

Sorry, I had forgotten to build before publishing. [email protected] should work normally.

Also, there are the tests to fix because of the addition of .flat() :

TypeError: this.props.children.flat is not a function

But this shouldn’t be a problem when installing.

Edit: Tests are now fixed. Moved every call to .flat() in a new method flatChildren() :

flatChildren() {
  return Array.prototype.flat.call(this.props.children);
}

from react-flip-page.

saricden avatar saricden commented on August 28, 2024

@darenju Awesome, you're the man! Thanks for fixing the tests :shipit:

from react-flip-page.

saricden avatar saricden commented on August 28, 2024

Works perfect in my implementation! 🍻

from react-flip-page.

darenju avatar darenju commented on August 28, 2024

And thank you for reporting & fixing this issue you found. It helps the component get better!

from react-flip-page.

saricden avatar saricden commented on August 28, 2024

👍 My pleasure, this component has been hugely helpful for me on the app I'm working on!

from react-flip-page.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.