Comments (10)
Update:
I think I've zeroed in on the problem. It appears the .map()
function is throwing it off, because instead of returning JSX elements directly as children, it returns them as an array of children, which seems to be where the bug is coming from.
from react-flip-page.
I have merged your PR and have published a new version of the package 1.6.3
that contains your fix.
Can you please confirm it works with this version?
Thank you!
from react-flip-page.
@darenju On it 👍
from react-flip-page.
Hey @darenju I installed version 1.6.3
via yarn add react-flip-page
but it appears the node_module
directory doesn't contain the dist
directory, so when I boot up my app it throws:
Module not found: Can't resolve 'react-flip-page' in '...'
Is this something on your end?
from react-flip-page.
If I copy over the dist
directory to node_modules/react-flip-page
all is well.
from react-flip-page.
Sorry, I had forgotten to build
before publishing. [email protected]
should work normally.
Also, there are the tests to fix because of the addition of .flat()
:
TypeError: this.props.children.flat is not a function
But this shouldn’t be a problem when installing.
Edit: Tests are now fixed. Moved every call to .flat()
in a new method flatChildren()
:
flatChildren() {
return Array.prototype.flat.call(this.props.children);
}
from react-flip-page.
@darenju Awesome, you're the man! Thanks for fixing the tests
from react-flip-page.
Works perfect in my implementation! 🍻
from react-flip-page.
And thank you for reporting & fixing this issue you found. It helps the component get better!
from react-flip-page.
👍 My pleasure, this component has been hugely helpful for me on the app I'm working on!
from react-flip-page.
Related Issues (20)
- How can I hide the page shadowing? HOT 6
- Issue: Input fields and drop-downs do not work HOT 1
- Could not find declaration for Module 'react-flip-page' HOT 2
- Error when adding responsive attribute HOT 2
- Error using ref in Functional Component TypeError: flipPage.gotoNextPage is not a function HOT 2
- An in-range update of babel7 is breaking the build 🚨 HOT 11
- Update the value of startAt after the first render HOT 1
- Using gotoNextPage after flip half page correctly but the other half flips immediately without notice HOT 3
- Security vulnerability for uglifyjs-webpack-plugin/serialize-javascript HOT 9
- Using on Mobile devices gives unexpected black background HOT 2
- flipOnTouch and goto methods - uncutPages does not work, half the animation does not work HOT 3
- Background Color Split in two for Span when it sits Between Pages HOT 2
- Next JS - ReferenceError: window is not defined HOT 1
- cannot use input element HOT 1
- Position of "middle of page" HOT 1
- Fragments HOT 4
- TypeError: Cannot set property 'FlipPage' of undefined HOT 1
- Is this supporting on react-native also ? HOT 2
- gotoPage(page) its not reflecting animation effect
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-flip-page.