Code Monkey home page Code Monkey logo

Comments (6)

darccio avatar darccio commented on August 22, 2024 1

It should be fixed now.

from mergo.

luisdavim avatar luisdavim commented on August 22, 2024

If I use Other map[string]*Other instead of Other map[string]Other it doesn't crash but I don't get the expected merge results the structures inside the map are replaced instead of merged.

from mergo.

svyotov avatar svyotov commented on August 22, 2024

This also panics:

package main

import (
	"fmt"

	"github.com/imdario/mergo"
)

type Other struct {
	Faz map[string]string
}

func main() {
	new := map[string]Other{
		"NoPanic":   Other{Faz: map[string]string{}},
		"Panic":     Other{},
		"AlsoPanic": Other{Faz: nil},
	}
	new2 := map[string]Other{
		"NoPanic": Other{
			Faz: map[string]string{
				"some": "some2",
			},
		},
		"Panic": Other{
			Faz: map[string]string{
				"some": "some2",
			},
		},
		"AlsoPanic": Other{
			Faz: map[string]string{
				"some": "some2",
			},
		},
	}
	fmt.Println(new)
	fmt.Println(new2)
	mergo.Merge(&new, new2, mergo.WithAppendSlice, mergo.WithOverride)
}

from mergo.

svyotov avatar svyotov commented on August 22, 2024

I think from my debugging that this is the reason why this is happening: https://stackoverflow.com/a/49147910/2213164

from mergo.

boosh avatar boosh commented on August 22, 2024

I had something similar. The following code in mergo was causing a panic:

if dst.IsNil() && !src.IsNil() {
    dst.Set(reflect.MakeMap(dst.Type()))
}

I fixed it by initialising a map in src. It seems this particular piece of code is at fault.

from mergo.

darccio avatar darccio commented on August 22, 2024

Reopening this issue as its PR introduced too many bugs.

from mergo.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.