Code Monkey home page Code Monkey logo

Comments (7)

dwbelliston avatar dwbelliston commented on September 13, 2024 11

I also had this issue, another fix is to handle the promises differently. Group all the promise calls to get candidates to an array, then waiting until all of them are resolved to add them to the dom.

    ...
    // Load contract data
    App.contracts.Election.deployed().then(function (instance) {
      electionInstance = instance;
      return electionInstance.candidatesCount();
    }).then(function (candidatesCount) {

      // Store all promised to get candidate info
      const promises = [];
      for (var i = 1; i <= candidatesCount; i++) {
        promises.push(electionInstance.candidates(i));
      }

      // Once all candidates are received, add to dom
      Promise.all(promises).then((candidates) => {
        var candidatesResults = $("#candidatesResults");
        candidatesResults.empty();

        var candidatesSelect = $('#candidatesSelect');
        candidatesSelect.empty();

        candidates.forEach(candidate => {
          var id = candidate[0];
          var name = candidate[1];
          var voteCount = candidate[2];

          // Render candidate Result
          var candidateTemplate = "<tr><th>" + id + "</th><td>" + name + "</td><td>" + voteCount + "</td></tr>"
          candidatesResults.append(candidateTemplate);

          // Render candidate ballot option
          var candidateOption = "<option value='" + id + "' >" + name + "</ option>"
          candidatesSelect.append(candidateOption);          
        })
      });

      return electionInstance.voters(App.account);
    }).then(function (hasVoted) {
    ...

from election.

bardawilpeter avatar bardawilpeter commented on September 13, 2024 8

You can just update the listenEvent to the below and it will work:

listenForEvents: function() {
App.contracts.Election.deployed().then(function(instance) {
// Restart Chrome if you are unable to receive this event
// This is a known issue with Metamask
// MetaMask/metamask-extension#2393
instance.votedEvent({}, {
fromBlock: 'latest',
toBlock: 'latest'
}).watch(function(error, event) {
console.log("event triggered", event)
// Reload when a new vote is recorded
App.render();
});
});
},

from election.

asdimitrov13 avatar asdimitrov13 commented on September 13, 2024

I have noticed the same thing, I think it's got something to do with the async calls from the promises, however, I couldn't identify the root of the problem myself.

from election.

popeyebot avatar popeyebot commented on September 13, 2024

Thanks peter0o, it is prefect !

from election.

 avatar commented on September 13, 2024

@bardawilpeter But if you change account and refresh again, the first refresh double render again.

from election.

yodaster avatar yodaster commented on September 13, 2024

@bardawilpeter I agree with killermu94. As soon as you do the first refresh, it is still double rendered. The second refresh works correctly

from election.

moseley avatar moseley commented on September 13, 2024

I added a watch event for account change. Added App.listenForAccountChange() in the initContract function.

listenForAccountChange: function() {
    ethereum.on('accountsChanged', function (accounts) {
        App.account = accounts[0];
        App.render();
    })
},

from election.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.