Is it necessary to deep clone the state when dispatching? about observable-store HOT 7 CLOSED

The reason that's done is due to change detection in libraries/frameworks. In Angular for example, without cloning the dispatched object the object reference wouldn't change so the UI wouldn't know to update without manual coding.

While the deepCloneState value could be passed into the dispatchState function, that could potentially break previous behavior in existing apps using the library so I'm hesitant to change that functionality right now.

from observable-store.

Maybe adding a global setting which wouldn't break existing behavior and needs to be enabled manually?

I'm using it a bit like redux and create new object references before passing them to setState. Change detection seems to work fine even without deep cloning.

I think deep cloning can also be problematic if performance is important for a specific use case.

from observable-store.

I don't want to add any additional properties at this point (trying to keep the API as basic as possible....which is proving challenging to do over time :-)). While I don't have the bandwidth to implement the change right now to stop cloning during a dispatch (when deepCloneState is false), let me think it over more. I suspect it won't impact many (if any) people but I'm always careful there.

If you end up having time to submit a PR that modifies that behavior to fit what you need I'm happy to consider that as well and run it through some scenarios I have when I get some time next week.

from observable-store.

Yep, I understand it's hard to keep things simple :-)

I'll also think about this a bit more and submit my suggestion as a merge request (I'm already using a patched version of the lib for our app).

from observable-store.

That sounds great. I'll definitely give that more consideration because I kind of feel that if someone set deep cloning to false then the dispatch shouldn't need to deep clone given that they knew what they were doing when they set it to false.

If you're able to submit a PR for what you've modified for your scenario I'll look it over more. Thanks!

from observable-store.

Hi @fifafu. You're probably tied up with other things I know but if you get a chance to submit a PR with the changes you wanted let me know. Happy to look at it and see the impact on existing usage.

from observable-store.

Going to close this for now but feel free to re-open if you get a chance to submit the code you mentioned.

from observable-store.