Code Monkey home page Code Monkey logo

Comments (17)

yilksd avatar yilksd commented on May 30, 2024

我的想法是对scrapbook侧边栏条目的图标和标题采取不同操作。直接点击网页标题打开网页,按ctrl+左键在新标签页打开。按ctrl+左键点击图标可以多选。
主要是希望把条目标题看成网页上的链接一样处理,各种操作方式同对网页链接的操作方式保持一致,点击打开,ctrl+左键新标签页打开什么的;而网页图标则类似桌面上的文件图标,点击选择,ctrl+点击多选。

from firefox-scrapbook.

Misymonds avatar Misymonds commented on May 30, 2024

(Please excuse my bad english): I need multiple selection support in the main sidebar too. And its very important for me in my way to work with scrapbook. But not the "shift/ctrl+click=multiple selection" or the "ctrl+click=multiple selection" (these are for my way to work less important functions). I normally use (and that does'nt work in the sidebar of Scrapbook X - but in the manage window it does - in Scrapbook by Gomita also in the sidebar) to hold down the shift-key und go down or up with the cursor-keys. My problem is that there is currently no way anywhere for a multiple selection in the sidebar. At least i didn't found a way to do this. That is almost a criterion for exclusion to use Scrapbook X - but not really :-).
Scrapbook is one of my most favorite apps - i love it very much - i just cannot live without :-) And Scrapbook X seems on the whole meanwhile the better choice as Scrapbook by Gomita - thank you very much for your work, it makes my life a little a better...

from firefox-scrapbook.

BrenBarn avatar BrenBarn commented on May 30, 2024

Personally, I do not like the behavior that a single click opens the page. When I see something like a list of items in a sidebar, I want to click to select an item, not actually do anything with it, just like I would in a file explorer or the like. So I would propose:

  • click = select
  • double-click = open
  • ctrl/shift+click = multiple select
  • ctrl/shift+double-click = open in new tab

Ultimately I think the best thing is to make it an option. Let users choose the behavior of each click/key combo.

from firefox-scrapbook.

Kerenok avatar Kerenok commented on May 30, 2024

Agree with BrenBarn proposal on the mapping of keys to actions. After years of using Scrapbook, no easy multiple selection in main sidebar is preventing me from shifting to Scrapbook X.

from firefox-scrapbook.

pascallothar avatar pascallothar commented on May 30, 2024

Hello @danny0838 ,

I could not say things in a better way than BrenBarn did. I agree with all the points he mentionned.

But, I have to mention that, for Mac OS X, it would be:

  • click = select
  • double-click = open
  • cmd/shift+click = multiple select
  • cmd/shift+double-click = open in new tabS (meaning for several selected tabs)
  • cmd+double-click = open in a new tab (meaning for a single selected tab)

from firefox-scrapbook.

danny0838 avatar danny0838 commented on May 30, 2024

This feature was implemented in 1.13.0b6 and had some fixes in 1.13.0b7. Feel free to try on it and give us a feedback.

Basically we added an option "Use manage mode in the sidebar", which makes the sidebar work just like the manage window. Meanwhile, we have modified several key and mouse behaviors for some reason. Here is a simple list.

ScrapBoook 1.13.0b7

In the sidebar (non-manage mode)

  • LeftClick (on twisty): Toggle folder.
  • LeftClick: Open item. Toggle folder.
  • Ctrl/Shift+LeftClick: Open item in new tab. Toggle folder.
  • MidClick: Open item in new tab.
  • DblClick: Toggle folder.
  • Enter: Toggle folder. Open item.
  • Ctrl/Shift+Enter: Toggle folder. Open item in new tab.
  • Space: Open item.
  • Ctrl/Shift+Space: Open item in new tab.
  • Up: Move up.
  • Down: Move down.
  • Left: Collapse folder. Move to parent item.
  • Right: Expand folder. Move to first child item.

In the "Manage" window (or sidebar in manage mode)

  • LeftClick (on twisty): Toggle folder.
  • LeftClick: Select item.
  • Ctrl+LeftClick: Add item to selection.
  • Shift+LeftClick: Add items to selection.
  • MidClick: Open item in new tab.
  • DblClick: Toggle folder.
  • DblLeftClick: Open item.
  • Ctrl/Shift+DblClick: Open item in new tab.
  • Enter: Toggle folder. Open item.
  • Ctrl/Shift+Enter: Toggle folder. Open item in new tab.
  • Space: (No effect)
  • Ctrl+Space: Toggle item from selection.
  • Up: Move up.
  • Ctrl+Up: Move up while keeping current selection.
  • Shift+Up: Move up and add it to selection.
  • Down: Move down.
  • Ctrl+Down: Move down while keeping current selection.
  • Shift+Down: Move down and add it to selection.
  • Left: Collapse folder. Move to parent item.
  • Right: Expand folder. Move to first child item.

In the folder picker window

  • LeftClick (on twisty): Toggle folder.
  • LeftClick: Select item.
  • DblClick: Toggle folder.
  • Enter: Toggle folder.
  • Up: Move up and select it.
  • Down: Move down and select it.
  • Left: Collapse folder. Move to parent item and select it.
  • Right: Expand folder. Move to first child item and select it.

ScrapBoook 1.12.36 (for comparison)

In the sidebar

  • LeftClick (on twisty): Toggle folder.
  • LeftClick: Toggle folder. Open item.
  • Ctrl/Shift+LeftClick: Toggle folder. Open item in new tab.
  • MidClick: Open item in new tab.
  • DblClick: Toggle folder.
  • Enter: Toggle folder. Open item.
  • Ctrl/Shift+Enter: Toggle folder. Open item in new tab.
  • Space: (No effect)
  • Ctrl/Shift+Space: (No effect)
  • Up: Move up.
  • Down: Move down.
  • Left: Collapse folder. Move to parent item.
  • Right: Expand folder. Move to first child item.

In the "Manage" window

  • LeftClick (on twisty): Toggle folder.
  • LeftClick: Toggle folder and select item.
  • Ctrl+LeftClick: Toggle folder and add item to selection.
  • Shift+LeftClick: Toggle folder and add items to selection.
  • MidClick: Open item in new tab.
  • DblClick: Toggle folder.
  • DblLeftClick: Open item.
  • Ctrl/Shift+DblClick: Open item in new tab and add item(s) to selection.
  • Enter: Toggle folder. Open item.
  • Ctrl/Shift+Enter: Toggle folder. Open item in new tab.
  • Space: (No effect)
  • Ctrl+Space: (No effect)
  • Up: Move up.
  • Ctrl+Up: Move up while keeping current selection.
  • Shift+Up: Move up and add it to selection.
  • Down: Move down.
  • Ctrl+Down: Move down while keeping current selection.
  • Shift+Down: Move down and add it to selection.
  • Left: Collapse folder. Move to parent item.
  • Right: Expand folder. Move to first child item.

In the folder picker window

  • LeftClick (on twisty): Toggle folder.
  • LeftClick: Toggle folder and select item.
  • DblClick: Toggle folder.
  • Enter: Toggle folder.
  • Up: Move up and select it.
  • Down: Move down and select it.
  • Left: Collapse folder. Move to parent item and select it.
  • Right: Expand folder. Move to first child item and select it.

Notes:

  • "Twisty" is the small triangle aside a folder item to toggle a folder and indicate its status.
  • DblClick fires on pressing any mouse button twice, including left, middle, or right. Also, the two single clicks have effect before the dblclick fires.
  • The full support of Mac could be delayed since there are still some unresolved and unrecognized issues.

from firefox-scrapbook.

pascallothar avatar pascallothar commented on May 30, 2024

You wrote (for example) «

ScrapBoook 1.13.0b7

In the sidebar (non-manage mode)

LeftClick: Open item. Toggle folder.

» in bold, and «

ScrapBoook 1.12.36 (for comparison)

In the sidebar

LeftClick: Toggle folder. Open item.

» not in bold.

I am not sure to understand the difference. I guess you were in an edition task, but that you forgot to finish it. Didn't you? Or should I take vitamins? :-) . I guess you wanted to say something like:
« On item or "non-folder-type folder", does open it. On standard folder, does toggle it. »,
didn't you?


You said « The full support of Mac could be delayed since there are still some unresolved and unrecognized issues. ». But I can say that, thanks to you, it is already better :-) . Regarding the current topic, does it help you to know that Cmd key == Apple key == HARDWARE equivalent of Windows key (actually, there is no problem to put a Windows keyboard on an Intel Mac)? Though if it comes to functionality, Mac use usually the Cmd/Apple/Windows key where Windows would use Ctrl key (even if HARDWARE equivalent of Ctrl key is Ctrl key itself).

You said « DblClick fires on pressing any mouse button twice, including left, middle, or right. ». Do I have to understand that, on Windows, if you DblRightClick or DblMidClick and item, the result is the same as if you would DblLeftClick it? Than it is not the same on Mac, as you can see below. But I don't see any problem there, since usually people don't use DblRightClick or DblMidClick on items. Do they?

You said « Also, the two single clicks have effect before the dblclick fires. ». I guess you meant that, for example, when you Shift+DoubleLeftClick an item in 1.12.36, it will open it twice in two tabs. Yes, it sounds to me to be normal.


Following is the (detailed) test on ScrapBoook 1.13.0b7 on my Mac.

I have installed a external mouse to test the Middle-Click.

Note: Because I am on Mac, I use Cmd key where you usually use Ctrl.


In the sidebar (non-manage mode):

  • LeftClick (on twisty): Toggle. ( == OK)
  • LeftClick: Open item or "non-folder-type folder" in the CURRENT tab. Toggle standard folder. ( == OK)
  • Cmd+LeftClick: Same as LeftClick, but SHOULD do: Open item or "non-folder-type folder" in a NEW tab. Toggle standard folder.
  • Shift+LeftClick: Open item or "non-folder-type folder" in a NEW tab. Toggle standard folder. ( == OK, ***but why not to open in a new WINDOW, since Cmd+LeftClick (or Ctrl+LeftClick on Windows) already open in a new TAB?)
  • MidClick: Open item or "non-folder-type folder" in a NEW tab. Toggle standard folder. ( == OK)
  • DblLeftClick: Open item in the CURRENT tab. Toggle and open "non-folder-type folder" in the CURRENT tab. Toggle standard folder. ( == OK)
  • (DblMidClick: Open item in 2 new tabs. Toggle and open "non-folder-type folder" in 2 new tabs. Toggle standard folder. ( == Not that bad))
  • (DblRightClick: Contextual menu on items. Contextual menu + toggle "non-folder-type folder" or standard folder. ( == Not bad))
  • Enter: Open item in the CURRENT tab. Toggle "non-folder-type folder" (I don't know if it SHOULD OR NOT open it). Toggle standard folder.
  • Cmd+Enter: Open item in CURRENT tab (SHOULD be in a NEW one). Open "non-folder-type folder" in CURRENT tab (SHOULD be in a NEW one) (I don't know if it SHOULD OR NOT toggle it). DOESN'T toggle standard folder (You said that, on Windows, it does).
  • Shift+Enter: Open item in NEW tab. Open "non-folder-type folder" in NEW tab (I don't know if it SHOULD OR NOT toggle it). DOESN'T toggle standard folder (You said that, on Windows, it does). ***(Could open in a new WINDOW (see above: WINDOW vs TAB))
  • Space: Open item or "non-folder-type folder" in CURRENT tab. Nothing on standard folder. ( == OK)
  • Cmd+Space: Open item or "non-folder-type folder" in CURRENT tab (SHOULD be in a NEW one). Nothing on standard folder.
  • Shift+Space: Open item or "non-folder-type folder" in NEW tab. Nothing on standard folder. ( == OK, ***but see above: WINDOW vs TAB)
  • Up: Move up. ( == OK)
  • Down: Move down. ( == OK)
  • Left: Collapse folder. Move to parent item. ( == OK)
  • Right: Expand folder. Move to first child item. ( == OK)

In the "Manage" window (or sidebar in manage mode):

  • LeftClick (on twisty): Toggle. ( == OK)
  • LeftClick: Select. ( == OK)
  • Cmd+LeftClick: Add/Remove one item (or ... ) to selection. ( == OK)
  • Shift+LeftClick: Add multiple items (or ... ) to selection. ( == OK)
  • MidClick: Open item or "non-folder-type folder" in NEW tab. On standard folder, only select.( == OK)
  • DblLeftClick: Open item in CURRENT tab. Toggle "non-folder-type folder" (DOESN'T open it in the CURRENT tab (It SHOULD, since there is no other DIRECT way to open it with only the mouse))). Toggle standard folder.
  • (DblMidClick: Open item in 2 new tabs. Toggle and open "non-folder-type folder" in 2 new tabs. Toggle standard folder. ( == Not that bad))
  • (DblRightClick: Contextual menu on items. Contextual menu + toggle "non-folder-type folder" or standard folder. ( == Not bad))
  • Cmd+DblLeftClick: Open item in CURRENT tab (SHOULD be in a NEW one). Toggle "non-folder-type folder" (DOESN'T open it in a NEW tab (It SHOULD, since there is no other DIRECT way to open it with only the mouse))). Toggle standard folder. (NOTE: If some other item(s) were already selected, other items than the opened/toggled one will be selected afterwhile, making it difficult to see which one was opened/toggled. Since there is ONLY ONE opened/toggled, it would make more sense if only one would remain selected.)
  • Shift+DblLeftClick: Open item in NEW tab. Toggle "non-folder-type folder" (DOESN'T open it in a NEW tab (It SHOULD, since there is no other DIRECT way to open it with only the mouse))). Toggle standard folder. (see NOTE above) ***(see above: WINDOW vs TAB)
  • Enter: Open item in the CURRENT tab. Toggle "non-folder-type folder" (I don't know if it SHOULD OR NOT open it). Toggle standard folder.
  • Shift+Enter: Open item in NEW tab. Open "non-folder-type folder" in NEW tab (I don't know if it SHOULD OR NOT toggle it). DOESN'T toggle standard folder (You said that, on Windows, it does). ***(Could be in a new WINDOW (see above: WINDOW vs TAB))
  • Cmd+Enter: Same than Shift+Enter, but in CURRENT tab (SHOULD be in a NEW one).
  • Space: (No effect) ( == OK)
  • Cmd+Space: Toggle item from selection. ( == OK)
  • Up: Move up. ( == OK)
  • Cmd+Up: Move up while keeping current selection. (Works. But on Mac, you have no clue on which item your are, unless you calculate it. Perhaps, on Windows, is there something like a background color (other than blue or white) to see where you are? Anyway, since I only use the clicks and the modifiers.)
  • Shift+Up: Move up and add it to selection. ( == OK)
  • Down: Move down. ( == OK)
  • Cmd+Down: Move down while keeping current selection. (As I mentioned it for Cmd+Up, I am able to use Cmd+Space/Up/Down and Shift+Up/Down to make a "complex" selection, but it is training my memory and my eyes :-D
  • Shift+Down: Move down and add it to selection. ( == OK)
  • Left: Collapse folder. Move to parent item. ( == OK)
  • Right: Expand folder. Move to first child item. ( == OK)

In the folder picker window: ( All are OK)

  • LeftClick (on twisty): Toggle folder.
  • LeftClick: Select item.
  • DblClick: Toggle folder.
  • Enter: Toggle folder.
  • Up: Move up and select it.
  • Down: Move down and select it.
  • Left: Collapse folder. Move to parent item and select it.
  • Right: Expand folder. Move to first child item and select it.

from firefox-scrapbook.

Kerenok avatar Kerenok commented on May 30, 2024

Thanks to @danny0838 , since v1.13.0, I can know shift to Scrapbook X. Good work!

from firefox-scrapbook.

danny0838 avatar danny0838 commented on May 30, 2024

We at least have basic support for multiple selection in the side bar now in 1.13.*. There might be details that can be improved, though, and it's welcome to provide more feedback about this.

from firefox-scrapbook.

BrenBarn avatar BrenBarn commented on May 30, 2024

Has the version with this fix been officially released?

from firefox-scrapbook.

danny0838 avatar danny0838 commented on May 30, 2024

It has been included in beta version since ScrapBook X 1.13.0b6 and is likely to be included in next major release 1.13.0.

from firefox-scrapbook.

BrenBarn avatar BrenBarn commented on May 30, 2024

So I guess that's a no then. Any idea when 1.13.0 will be released?

from firefox-scrapbook.

danny0838 avatar danny0838 commented on May 30, 2024

@BrenBarn The release date was originally scheduled on 8/1, and we are overdue now due to several newly discovered issues and unresolved issues. You can see v1.13.0 milestone for our plan and the list of pending issues.

from firefox-scrapbook.

pascallothar avatar pascallothar commented on May 30, 2024

@danny0838 ,

During my use of Scrapbook X, I have noticed that you corrected certain behaviors for the clicks in the sidebar, so I made a new test to compare with the previous one. I have linked the result FYI.


When I was in the page about:config, I have seen that the "User" can add some new custom entries.

about config

I am not sure what it is for. But I was wondering if it could be used to assign new values to some "Constants" in Scrapbook X. Are the clicking behaviors implemented in a way that some kind of Constants are defined? And if so, are those Constants accessible from about:config?


If it is not possible to customize this way, would you mind to re-think the behavior of the DblLeftClick on "non-folder-type folder" in "Manage mode"?

For the moment, in "Manage mode", the only way to open a "non-folder-type folder" with only the mouse, is to open the contextual menu by right-clicking and then choose "Open" or "Open in New Tab". The intuitive behavior would be to open it by double-clicking it, as for a normal item.

For the moment, double-clicking it will toggle Expand/Collapse the "non-folder-type folder" as for a normal folder. Since we have twisties to do that, it is unnecessary.

Even if it is not a problem to let the double-click toggle a standard folder (even if it is redundant with the click on the twisty), the right behavior for a "non-folder-type folder" would be to open it in the CURRENT tab (and in a NEW tab if Cmd or Shift is down) and NOT to toggle it at all. Because, when a "non-folder-type folder" is expanded (collapsed) and you double-click it to open it, you just want to open it and not to see the "non-folder-type folder" collapsed (expanded) afterwards. You would need to click once more on the twisty to bring it to its previous state.


clicks

from firefox-scrapbook.

danny0838 avatar danny0838 commented on May 30, 2024

@pascallothar Double click to toggle a folder in a data tree is a behavior natively provided by Firefox and it would be more difficult to block the behavior.

Double-click to toggle a folder is a behavior widely implemented in most file browser in the OS, which also has a twisty for folder expanding. Also, in the context of a manage window the user is unlikely willing to open a page, so it can still be more desirable here.

Maybe it is less desirable for the sidebar in manage mode, but changing the behavior only for the sidebar causes an inconsistency and may confuse the user. We'll keep current design until we come up with a more comprehensive solution.

from firefox-scrapbook.

pascallothar avatar pascallothar commented on May 30, 2024

Double-click to toggle a folder is a behavior widely implemented in most file browser in the OS, which also has a twisty for folder expanding.

Yes, but they don't have to deal with the "non-folder type folder" witch is a improvement they don't need to use. The purpose of the "non-folder type folder" is to be used ALSO as a standard item would be.

Also, in the context of a manage window the user is unlikely willing to open a page, so it can still be more desirable here.

The "non-folder type folder" is a NEW and uncommon feature, so we cannot talk about a change in their habits. In the "manage window", double-clicking a standard item will open a page, so what is the difference?

Maybe it is less desirable for the sidebar in manage mode,

As you say, it is less desirable. But what is of more importance is that there is no other easy way to open the "non-folder type folder" as a standard item.
I would say, that, when in the sidebar, when going through the items (to remember their actual content), it is contra-intuitive and even less convivial to have to open the "non-folder type folder" ITEMS in a different way than the standard ITEMS.

Double click to toggle a folder in a data tree is a behavior natively provided by Firefox and it would be more difficult to block the behavior.

Oh, I see.
But, do you think it would be possible to choose with about:config to "remap" or "redirect" the Cmd+DblLeftClick to Cmd+Enter (and the same for Shift) with something like (very approximative!!!) OnDblClick == Press(Cmd, Enter)? Because Cmd+Enter and Shift+Enter are doing exactly what I would expect of Cmd+DblLeftClick and Shift+DblLeftClick.

from firefox-scrapbook.

pascallothar avatar pascallothar commented on May 30, 2024

DblLeftClick, Cmd+DblLeftClick and Shift+DblLeftClick on a "non-folder type folder" now work perfect.

Awesome!

Thank you very much @danny0838

from firefox-scrapbook.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.