Code Monkey home page Code Monkey logo

Comments (10)

danny0838 avatar danny0838 commented on May 30, 2024

I cannot reproduce this problem. Could you please recheck the HTML source of the captured pages to make sure whether the images/media/fonts are really saved to the local disk?

We had redefined "Capture images" and "Capture media" in ScrapBook 1.7.0, which tells that when unchecked, embedded images and media are linked to the source URL instead of saved to the local disk. This behavior is different with older ScrapBook versions, which removed images or media completely from the captured HTML.

from firefox-scrapbook.

tanmatra avatar tanmatra commented on May 30, 2024

Ok, but can it be made option for not to capture images at all?

Also, issue with embedded fonts is still intact - .woff, .eot and .ttf files is captured with pages if they specified.

from firefox-scrapbook.

danny0838 avatar danny0838 commented on May 30, 2024

Currently there is not an isolate option for not capturing fonts except not capturing styles.

It is technically possible not to capture images and/or fonts. Nevertheless, in my point of view, ScrapBook should capture pages as more primitive as possible, and I don't tend to make so many options that are not really important, especially those bothers the primitivity.

I'll need some feedback so that I can redesign the UI in a better way. Would you like to talk about why you might need an option not to capture images and/or fonts?

from firefox-scrapbook.

mirceglavni avatar mirceglavni commented on May 30, 2024

This is related to the problem that when you want to capture only some part of the page, the elements of the whole page are downloaded neveretheless.

from firefox-scrapbook.

danny0838 avatar danny0838 commented on May 30, 2024

@mirceglavni What do you mean by "the elements of the whole page are downloaded"? It is for sure that the page css, images and fonts used by the page css, page js, and metadata (mostly in the node) be downloaded in a section capture. While images, media, or files refered only by the section that are not selected should never be downloaded in a section capture - if it happens, there's probably something wrong.

from firefox-scrapbook.

mirceglavni avatar mirceglavni commented on May 30, 2024

Just tested it again on this web-site: http://www.cnbc.com/id/102094988?trknav=homestack:topnews:1
I selected the text from "After a swift and...." to "see how the data shakes out in December". So, no pictures or any other elements in this part. Choose capture selection, and looked with Show Files option in the data-folder, where I found 66 files totaling 2,39 MB. Some pictures shown on the web-site (but as I said, there were none in the selection), the usual social-crap logos etc.
Can you reproduce this?

from firefox-scrapbook.

danny0838 avatar danny0838 commented on May 30, 2024

@mirceglavni I retested it and it turns out to be "as expected". Images not included in the selection are not downloaded, which can be illustrated via comparing with full page capture, which says 136 files and 3.63 MB.
Some font files and images are indeed captured because they are refered either by the css or by the metadata. Sadly we currently don't have the technique to crop only the css parts that are really used by the selected part of the page, so the full css - including images refered by - are downloaded, making the capture rather fat.
This is somehow unintuitive and I'll keep seeking for a solution. Before that we may have to uncheck the "Styles" option to get a light-weight capture.

from firefox-scrapbook.

mirceglavni avatar mirceglavni commented on May 30, 2024

Thanks for looking into this and giving me feedback. I just tried it again and compared it with the original scrapbook extension. Highlighted again a part of cnbc article (not the previous one), and downloaded the selection with both scrapbooks.
Scrapbook (original).: 21 files, cca 900 KB
Scrapbook x: 65 files, cca 2,1 MB.

I'm no coder, but could you use part of the "old code" (from the original scrapbook) for capturing? Or would this hinder the new functions in scrapbook x?
Once again, thank you for beeing so supportive.

from firefox-scrapbook.

danny0838 avatar danny0838 commented on May 30, 2024

Try capture the full page of some CNBC articles and you'll find that there are bugs for original ScrapBook to take an exact snapshot, as well as the exact information in the css. I'm not going to work around like this since preciseness is more important than size.

from firefox-scrapbook.

danny0838 avatar danny0838 commented on May 30, 2024

In 1.12.0a30, capture options "Images" and "Media" are again redefined to a way more similar to old ScrapBook behavior - that blanks the image/media if unchecked.
A new option "Link to source for files not to capture" is introduced for the behavior of pre 1.12.0a30 behavior - that links to the Images/Media/Fonts source if checked (and "Images"/"Media"/"Fonts" unchecked). This is turned off by default since it seems to be more confusing.
Hope this solved the problem. If there's further feedback please let me know.

from firefox-scrapbook.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.