parseUrl craps on a null url about node-feedparser HOT 2 CLOSED

i suggest something like this in the beginning of parseUrl:

if(!url){
var e = new Error();
e.message = 'FeedParser.parseUrl does not accept null or undefined urls';
process.nextTick(function() {
if ('function' === typeof options)
callback = options;
callback(e);
});
return;
}

from node-feedparser.

I wanted to think about this -- because I agree that the parameter handling is deficient. I'll be addressing that. But I don't agree that the failure to provide a url to the function should do anything but cause an error to be thrown. I'm actually going to explicitly throw going forward.

Errors the library encounters should get handled gracefully and passed (or emitted), but incorrect usage should throw.

Holding this open until the parameter handling changes land.

from node-feedparser.