deserialize Included block about json-api-serializer HOT 7 CLOSED

Hi @ungrim97,

You are right, actually deserialize function do nothing with the included resources.
I actually use this library on server side only, so I never needed to deserialize these included resources.

It would be great if the deserialize function can do it.
I will investigate further on how to do it.

a PR is welcome, Thanks.

from json-api-serializer.

@danivek Cheers for the response. We are using it server side as well but have some POST/PUT requests from Ember Data that have included resources that need to be deserialised. Currently we do this manually.

Will try and find time to put a PR together.

from json-api-serializer.

@ungrim97 As you use it on server side, and according to the JSONAPI specification, on creating or updating a resource, the spec says nothing about included key on input data.
Also PUT method is not allowed by the spec.

I am surprised that Ember uses it like this.

Also, it could be great to have this feature for client side deserialization purposes. So why not...

from json-api-serializer.

@ungrim97, I made a try on branch deserialize-included

Please tell me if it corresponds to your needs

Thanks

from json-api-serializer.

@ungrim97 Any feedback ?

from json-api-serializer.

Sorry @danivek work has been crazy. This looks perfect but I have only tested with direct included (included resources for the primary resource, not included resources for any included resources)

from json-api-serializer.

No problem @ungrim97, I know that. Good catch, I modify my test to also test the second case (included resources for any included resources)

Thanks

from json-api-serializer.