Code Monkey home page Code Monkey logo

Comments (5)

munizart avatar munizart commented on May 22, 2024 2

@danilowoz agreed, although the title is free for the author to choose.
Totally agree about a section for breaking changes.
I think we could replace Fix issue #[issue number] just Related issue #[issue number]. This would, probably, encourages contributors to open an issue to discuss changes.
BTW, I think there's things left to discuss here, like the checklists items, how many reviewers should be tagged (if it should).

Also the necessity of a contributing guide or code of conduct is something to discuss in another issue.

from react-content-loader.

danilowoz avatar danilowoz commented on May 22, 2024

Sounds great!

But not all pull request will be about issues/fixes. It can be a new feature, improvements, etc. Maybe you just need to improve the title, you know?
And you can add a new section, asking if the change is a "breaking change" or not?

What do you think?
Thanks

Greeting, xaropês

from react-content-loader.

danilowoz avatar danilowoz commented on May 22, 2024

Nice!
I'm waiting for you PR :)

from react-content-loader.

danilowoz avatar danilowoz commented on May 22, 2024

Hey @munizart, how are doing?
So, would you like to keep this issue with you? Or can I open the community to make it?
I think it is a great improvement and I want to solve that :)

Thanks

from react-content-loader.

munizart avatar munizart commented on May 22, 2024

@danilowoz sorry, right now I can't make it. But it would be great if someone could take it from here
🦄

from react-content-loader.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.