Code Monkey home page Code Monkey logo

Comments (2)

danielflower avatar danielflower commented on July 19, 2024

I would be tempted to delete the modulesToRelease option. I've never had to use it myself. In either case, it seems difficult to change how modulesToRelease works without it being a breaking change.

I wonder if deprecating modulesToRelease would be okay if forceRelease could be used instead. I definitely think always allowing optional group IDs would be a good idea.

Sounds fine for you to make a pull request - as long as it's small enough for me to understand and is non-breaking then go for it.

from multi-module-maven-release-plugin.

vigerlof avatar vigerlof commented on July 19, 2024

The modulesToRelease would be of use if you have a need to release only some of the maven projects within a repository even if other parts have been source changed as well. I do know of connected maven projects that have slightly different release cycle within the same repository and therefore could use this feature (No, I could not convince them to split the repository..).

Yes, in most cases changing modulesToRelease to use [groupid:]artifactId is not backward compatible as the only time it would be is when you keep all projects on top-level and use the artifactId as directory name. Good practice, but not a requirement..

moduleToRelease and forceRelease does two different things, so I can't see how the latter could be changed to include (parts of?) the first one.. forceRelease does not limit which projects to release as moduleToRelease does.

There might be an opening... JGit 4.7 was released a week ago. It fixes a problem of detecting path changes when there is projects within projects (DiffDetectorTest is not really testing this now, and has also been fooled by the jgit bug). Since JGit some time ago dropped Java 7 support, could that be used as a reason for making a major stepping as well as changing modulesToRelease parameter/dropping it+introducing new one? (I have a patch almost ready for the jgit update, pull req should be up shortly)

from multi-module-maven-release-plugin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.