Add AndroidX support about material-about-library HOT 18 CLOSED

Good point. I'll update the support library versions and add AndroidX support.

from material-about-library.

I tried using AndroidX (with jetifier on) but the MaterialAboutActivity doesn't provide any getResources() or startActivity(). getString etc
It was fine before I did the refactoring

from material-about-library.

i compiled by myself without testapp.
if someone need it with androidx: https://github.com/DerTyp7214/material-about-library/releases/tag/2.3.0

from material-about-library.

Hi guys, apologies for the delay.

Could you please test if 2.4.2 works?

Thanks

from material-about-library.

Do you know if it works yet with jetifier?

from material-about-library.

Actually I'm not sure. I'm still using Android Studio 3.1.4

from material-about-library.

jetifier

The latest AndroidX should be OK

gradle.properties

android.useAndroidX = true
android.enableJetifier = false

build gradle

implementation "com.google.android.material:material:$material_version"
implementation "androidx.appcompat:appcompat:$legacy_support_version"    
implementation "androidx.legacy:legacy-support-v4:$legacy_support_version"
implementation "androidx.legacy:legacy-support-v13:$legacy_support_version"

I really like to use your About library since there is a support for Licenses entry. But, I have just moved to AndroidX.

from material-about-library.

OK, I try to refactor everything in your library codes to AndroidX but the example app uses LicenseAdapter from GITHUB yshrsmz/LicenseAdapter which currently doesn't support AndroidX.

{update redacted into a new post reply}

from material-about-library.

Thanks for taking a look into it. The example using License adapter as an example actually isn't in the latest release, I'm wondering if supporting custom adapters is a good feature.

So you can confirm jetifier does not work with material about library? If this is the case, I'll probably create a new branch and support both support library and AndroidX versions separately.

On another note, how many libraries have you encountered that don't play well with AndroidX, I'm looking to migrate soon.

from material-about-library.

Thanks for taking a look into it. The example using License adapter as an example actually isn't in the latest release, I'm wondering if supporting custom adapters is a good feature.

So you can confirm jetifier does not work with material about library? If this is the case, I'll probably create a new branch and support both support library and AndroidX versions separately.

On another note, how many libraries have you encountered that don't play well with AndroidX, I'm looking to migrate soon.

I have tried set android.enableJetifier = true and it seems okay. But, I only change that part. So, obviously, I haven't done anything.

About custom adapter support, I think it is a choice and it looks fine to me.

On the other hand, the developer of LicenseAdapter seems inclined to support it yshrsmz/LicenseAdapter#53

from material-about-library.

Thanks. I would also like to add AndroidX support, however, I am more inclined to wait until AndroidX is more common because (correct me if I'm wrong) whilst a support library dep can be used with jetifier, an AndroidX dep can't be used in a support library project.

Would you agree here or do you think I should create two separate branches?

from material-about-library.

from material-about-library.

Released now! Keep in mind all future updates to support library will only happen in androidx.

from material-about-library.

I tried implementation "com.github.daniel-stoneuk:material-about-library:2.3.0" but I think the MaterialAboutCard.Builder.customAdapter is broken.

Update: OK, I understand 2.3.0 tag is the old one. I should use the one from DerTyp7214

from material-about-library.

@daniel-stoneuk I will try when I'm back from work

from material-about-library.

from material-about-library.

Brilliant! Hopefully support for @yshrsmz 's LicenseAdapter should make life a bit easier! @eclectice

from material-about-library.

The new version is working great, thank you.

from material-about-library.