Code Monkey home page Code Monkey logo

Comments (9)

dani-garcia avatar dani-garcia commented on May 23, 2024 1

Patch should be fixed in the latest commit, I'll try to get a release updating gulp-google-webfonts like @Savke mentions, to keep it close to the official release for now. Next release will include the future vault version with the fix mentioned by @firecat53 instead.

from bw_web_builds.

dani-garcia avatar dani-garcia commented on May 23, 2024 1

Fixed now in the latest release, thanks for all your help trying to locate this error!

from bw_web_builds.

Savke avatar Savke commented on May 23, 2024

I have similiar issues, but I am not using docker. Look at web-vault folder and search in file package.json. Find dev dependency gulp-google-webfonts I believe that is 4.0.0 It should be 4.1.0. Change that manually and then run install and run dist.
Ofc, delete node_modules folders, than do this
P.S. This is fix for v2.23.0 patch

from bw_web_builds.

firecat53 avatar firecat53 commented on May 23, 2024

@Savke thanks, but I'm not very familiar with Node. I can't find any reference to gulp-google-webfonts in either this bw_web_builds repo or in the bitwarden/web repo.

Does this recent commit have anything to do with the failure?

from bw_web_builds.

Savke avatar Savke commented on May 23, 2024

@firecat53 When You clone web-vault repo to your machine and checkout to the v2.23.0 branch, You have into cloned repo package.json and package-lock.json files. Look at package.json file and to as I mentioned in previous post. Than You can run sub:init && npm install && npm run dist

from bw_web_builds.

BlackDex avatar BlackDex commented on May 23, 2024

@firecat53 yes, that commit is indeed what would solve it.
We try to only use tagged versions from the bitwarden/web repo, since the master has a lot of other changes which arn't always used for a new tagged version, and thus could break stuff.

Also, cherry-picking doesn't seem to work.
The only thing you could try to do is use f8b0c2ffe43521d22321e95703415c5be5f455cc as the hash to see if that resolves the building and hoping to have not to much changes since v2.23.0.

from bw_web_builds.

firecat53 avatar firecat53 commented on May 23, 2024

Ah, thanks for the clarification! Checked out v2.23.0 and then was able to see the google-webfonts entry. I'll play with it some more when I get a chance.

from bw_web_builds.

firecat53 avatar firecat53 commented on May 23, 2024

FWIW, latest release 2.23.0b also fails to build (patch failure this time).

from bw_web_builds.

firecat53 avatar firecat53 commented on May 23, 2024

Worked great, thank you! Your work on this project is hugely appreciated by me and many others in this community!

from bw_web_builds.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.