Considering update to node 18? about bw_web_builds HOT 9 CLOSED

It looks like v2023.7.1 is still build using v16 too me:

• https://github.com/bitwarden/clients/actions/runs/5661201560/job/15338609821#step:4:14
• https://github.com/bitwarden/clients/actions/runs/5661201560/job/15338609821#step:5:10

Even the last Build Web trigger seems to be using v16: https://github.com/bitwarden/clients/actions/runs/5837240071/job/15832394685#step:5:10

So, until they change there CI/CD to v18, i want to keep it on v16.

from bw_web_builds.

Maybe it would be nice to report this to Bitwarden then.
But there are several issues with the cli for example using node 18.

• bitwarden/clients#3984
• bitwarden/clients#5876

So, again, until Bitwarden updates there build workflow too use node 18, and it doesn't cause issues, we stay on 16, EOL or not.
We don't have the manpower or knowledge to maintain our fix issues that arise when deviating.

from bw_web_builds.

Also, even the PR which updated that file did not changed the version of the web workflow to v18, see https://github.com/bitwarden/clients/pull/5205/files

That might have been an oversight, but I don't know.

from bw_web_builds.

I think we should reconsider this going forward, maybe inform upstream.

According to https://nodejs.dev/en/about/releases/ the node 16 LTS maintenance ends in less than two weeks (2023-09-11)

from bw_web_builds.

@BlackDex because node 16 does not receive any security updates anymore, I've asked Bitwarden Support and it seems it was an oversight. It will be fixed by bitwarden/clients#6421

from bw_web_builds.

@BlackDex because node 16 does not receive any security updates anymore, I've asked Bitwarden Support and it seems it was an oversight. It will be fixed by bitwarden/clients#6421

I haven't checked if uploading files with the cli still broken now.
Just hope nothing else will break hehe. But if we test it good enough it's fine by me.

from bw_web_builds.

The fix was merged. As far as I've tested it I also think that it should be fine to update to node 18 but we could also wait for the next release. Either way I have not created a commit since there already is #140 which would implement the same change.

from bw_web_builds.

The fix was merged. As far as I've tested it I also think that it should be fine to update to node 18 but we could also wait for the next release. Either way I have not created a commit since there already is #140 which would implement the same change.

@stefan0xC no it doesn't. That will cause a conflict since it still uses bullseye. It is also closed. From my point of view you may update it.

from bw_web_builds.

Ah, you're right. I did not notice. 😳

from bw_web_builds.