Comments (5)
That is odd. Trying to remember why I set it up that way to begin with, and failing. It's also interesting that this works with Angular 1.0.8, but not 1.2.15 (1.0.8 was the latest stable when I wrote the directive).
Have you tested the change you've presented here? If it works, go ahead and submit a PR with the change and I'll merge it in.
from angular-dynamic-forms.
Tested, indeed. PR in a moment.
from angular-dynamic-forms.
Not sure it's because of a difference between Angular versions, but whether or not jQuery is included. No idea what exactly is happening, but with jQuery included the result of $document
in that particular spot is very different. Will still submit the PR, I suppose… still catches error when jQuery is included which I imagine to be a common occurrence.
from angular-dynamic-forms.
Completely forgot about this discussion when I commented on your PR just now. Sorry about changing my mind like that.
jQuery and jqLite implement certain things differently. I suspect the actual fix to this will be to grab the documentElement
instead of the document
object, and to stop there instead. So $document.documentElement
instead of just $document
. (I'd say angular.element(":root")
if selectors were implemented in jqLite.)
from angular-dynamic-forms.
I've added such a check, so I'll close this issue. Feel free to reopen if I'm an idiot and did it wrong. 😁
from angular-dynamic-forms.
Related Issues (20)
- Usage of file input unclear HOT 2
- Unknown provider: dynformProvider <- dynform <- LoginCtrl HOT 2
- test
- checklist is not rendering showing error at option portion HOT 1
- File Upload Issue...Last 1 for this project I hope HOT 2
- Multi Column Form HOT 3
- Auto complete HOT 3
- how to add required in checklist HOT 3
- Regarding dynamically loading the template from a response from $http service - question/issue HOT 12
- HTML-first (Accessible) Usage? HOT 1
- Adding entries into custom class HOT 1
- How to use ng-show?
- Does this actually work? HOT 3
- How to add custom components like autosuggest, uib-datepicker in dynamic form
- How to add custom validations in dynamic form
- How to use the value of the ng-model in dynamic-forms.js file
- Refresh directive upon attrs.template (stdFormTemplate) change HOT 1
- Using ADF with Jhispter HOT 3
- Want to run it after clone HOT 4
- HTTP POST HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from angular-dynamic-forms.