"TypeError: Cannot read property 'nodeName' of undefined" from dynamic-forms.js:304:114 about angular-dynamic-forms HOT 5 CLOSED

That is odd. Trying to remember why I set it up that way to begin with, and failing. It's also interesting that this works with Angular 1.0.8, but not 1.2.15 (1.0.8 was the latest stable when I wrote the directive).

Have you tested the change you've presented here? If it works, go ahead and submit a PR with the change and I'll merge it in.

from angular-dynamic-forms.

Tested, indeed. PR in a moment.

from angular-dynamic-forms.

Not sure it's because of a difference between Angular versions, but whether or not jQuery is included. No idea what exactly is happening, but with jQuery included the result of $document in that particular spot is very different. Will still submit the PR, I suppose… still catches error when jQuery is included which I imagine to be a common occurrence.

from angular-dynamic-forms.

Completely forgot about this discussion when I commented on your PR just now. Sorry about changing my mind like that.

jQuery and jqLite implement certain things differently. I suspect the actual fix to this will be to grab the documentElement instead of the document object, and to stop there instead. So $document.documentElement instead of just $document. (I'd say angular.element(":root") if selectors were implemented in jqLite.)

from angular-dynamic-forms.

I've added such a check, so I'll close this issue. Feel free to reopen if I'm an idiot and did it wrong. 😁

from angular-dynamic-forms.