Code Monkey home page Code Monkey logo

Comments (5)

liarco avatar liarco commented on May 24, 2024 1

Thank you for your feedback! I've beed testing this action in the last few months and it was working fine, except for one time where I hit the same problem, but I thought that I had broken something so I started the "split" repo from scratch, re-run the failed jobs and everything synced properly, so it's a bit strange.

I totally agree with the .gitignore stuff, that's built with some templates from a PHPStorm extension, but it's way better to just use the rules we need.

I'm gonna try the following steps:

  • update the .gitignore files and other stuff to see if having both changed and new files changes the result
  • create a smaller reproducer where I try to isolate the issue (if there's any with the action)

I'm will update the issue as soon as I have some news.

from monorepo-split-github-action.

liarco avatar liarco commented on May 24, 2024 1

@TomasVotruba I think I found the problem...

I created a small reproducer and forked your action to run some tests, but I couldn't replicate the issue in any way... then I realized that I was using the @main tag version in order to pick my latest changes from the action and so I tried to do the same on my project: it worked as intended.

Looking at the README.md file from your repo, you suggest using version 2.1, but I was using 2.0 which didn't include the fix in #13.
But there's more: there is no 2.1 tag in this repository, so the latest stable version seems to be the 2.0 from April which is outdated, lacks some fixes and still has arguments with - instead of _.

Am I missing anything here?

from monorepo-split-github-action.

liarco avatar liarco commented on May 24, 2024 1

Fixed by https://github.com/symplify/monorepo-split-github-action/releases/tag/2.1

from monorepo-split-github-action.

TomasVotruba avatar TomasVotruba commented on May 24, 2024

Hi, thanks for reporting the issue. This is very hard to test, due to many layers of bash + git + symfony process layers. Many places can go wrong :)

I'm looking at repository and it's pretty huge. I recommend starting with something small, where you have files under control. E.g. 1 file split.

Personally I would narrow that huge .gitignore to 5-10 lines that you really need. It looks like copy-pasted from some all ignore tutorial. It may cause troubles with releasing. It was one of my "bugs" in the past, so I share it.

from monorepo-split-github-action.

TomasVotruba avatar TomasVotruba commented on May 24, 2024

@liarco Thank you 👍

from monorepo-split-github-action.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.