Code Monkey home page Code Monkey logo

Comments (3)

manicmaniac avatar manicmaniac commented on June 3, 2024 2

@jkmathew

I opened a PR to add ref option.

See #1399 and feel free to comment on it.

from danger.

jkmathew avatar jkmathew commented on June 3, 2024 1

@manicmaniac,

Thanks for your PR.

I confirmed that Danger 9.1.0 works even Git tag is passed to branch: parameter.
It also works well with commit hash.

From I understanding this is working with Danger 8.x as well.

from danger.

manicmaniac avatar manicmaniac commented on June 3, 2024

So I believe we can pass tags/commit hash also in the branch: parameter to danger.import_dangerfile,

I confirmed that Danger 9.1.0 works even Git tag is passed to branch: parameter.
It also works well with commit hash.

Thus all we have to do would be adding ref as an alias of branch parameter.

According to the document, it seems to work in GitLab too.

ref | string | yes | The name of branch, tag or commit.

from danger.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.