Code Monkey home page Code Monkey logo

Comments (9)

equalsraf avatar equalsraf commented on June 8, 2024 3

I was seeing a similar issue in Linux/X11 with an intel card.

I changed the hi-dpi value in settings.json to false, and was able to avoid the issue.

  "hiDPI": false,

from thdwb.

montyanderson avatar montyanderson commented on June 8, 2024 2

Also got this issue on Mac OS.

"hiDPI": false makes the window a little larger but still a small portion of the total window size.

from thdwb.

dyaskur avatar dyaskur commented on June 8, 2024

Screen Shot 1442-09-09 at 6 03 27 PANGERAN

my settings.json:

{
  "homepage":"thdwb://homepage/",
  "windowWidth": 1600,
  "windowHeight": 900,

  "hiDPI": false,

  "experimentalHTML": false,
  "experimentalLayout": false
}

from thdwb.

raff avatar raff commented on June 8, 2024

At least on MacOS it seems that when using hiDPI the scale is reversed. I.e. in https://github.com/danfragoso/thdwb/blob/master/mustard/window.go#L35:

window := &Window{ title: title, width: int(float32(width) / xscale), height: int(float32(height) / yscale), hiDPI: hiDPI,
it should really be:

width: int(float32(width) * xscale), height: int(float32(height) * yscale),

That makes the window content fill the window (but then it goes back to small with flicker on resize, so I think the same needs to be done wherever the window resize code is).

from thdwb.

bigwhite avatar bigwhite commented on June 8, 2024

I got this issue on Mac OS, too.

from thdwb.

ajzaff avatar ajzaff commented on June 8, 2024

@raff That seems plausible for the scale issue. The resize callback is here: https://github.com/danfragoso/thdwb/blob/master/mustard/window.go#L139
I pushed the fix to my branch if anyone cares to try it? https://github.com/ajzaff/thdwb/tree/feature-content-scale-23

FWIW hiDPI did not work well on my chromebook even with my fix.

from thdwb.

danfragoso avatar danfragoso commented on June 8, 2024

Hi, sorry for the delay, I've been really busy with work this couple of weeks. I fixed the scaling issue on linux with commit 088ec74, can you guys try it again?

@ronangaillard @dyaskur @montyanderson @raff @bigwhite @ajzaff

from thdwb.

dyaskur avatar dyaskur commented on June 8, 2024

On my mac still has same result

Screen Shot 1442-09-16 at 2 29 18 PANGERAN

from thdwb.

raff avatar raff commented on June 8, 2024

@dyaskur, if you applied https://github.com/ajzaff/thdwb/tree/feature-content-scale-23, make sure you have hiDPI=true in settings.json.

The fix is still not perfect (on resizes there are cases depending on the window size where the screen goes white) but mostly works.

from thdwb.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.