Comments (5)
Thanks. I've made the changes to utils.c, and tested it.
The file is attached.
Original comment by [email protected]
on 5 Dec 2009 at 5:59
Attachments:
from leptonica.
This fix will be in 1.64.
Original comment by [email protected]
on 5 Dec 2009 at 6:00
- Changed state: Accepted
from leptonica.
Just took a look at your change to genPathname() in utils.c
You do:
dirlen = strlen(charbuf);
if (charbuf[dirlen - 1] != sepchar) /* append sepchar */
charbuf[dirlen] = sepchar;
strncat(charbuf, fname, namelen);
return charbuf;
Offhand, that looks to me like you clobber charbuf's trailing null with
sepchar? In
which case, strncat is going to be very confused. I think you still need my:
charbuf[dirlen+1] = '\0';
Original comment by [email protected]
on 8 Dec 2009 at 8:47
from leptonica.
I don't think so. The calloc initialized charbuf to 0.
After copying the (possibly munged) directory name, and appending
the sepchar, all the remaining chars in charbuf are still 0.
That's why I left it off.
Original comment by [email protected]
on 8 Dec 2009 at 10:19
from leptonica.
Fixed in 1.64
Original comment by [email protected]
on 3 Jan 2010 at 11:31
- Changed state: Fixed
from leptonica.
Related Issues (20)
- Suggest noting that libtiff must have been compiled with JPEG compression support for tests to run correctly HOT 4
- Leptonica 1.84 release schedule HOT 28
- How to detect the four corners of paper or ID card HOT 8
- 1.84.0 fails to build in FreeBSD 14.0 due missing reference to libm using CMake HOT 24
- CMake build in 1.84.0 adds include to non-existant path
- 1.84.1: compile time warnings HOT 3
- pixWriteJp2k: unexpected strong color artifacts on featureless image HOT 7
- pixOrientDetect with .bmp file HOT 6
- Logic error in pixcmapIsValid() HOT 5
- Regression: file not found on MacOS when opening /tmp file HOT 2
- Identifying and removing asterisks HOT 8
- pixDeskewGeneral(...) failing to detect a 45 degree skew? HOT 2
- Application crashing while disposing Pix.Create object HOT 5
- get minarea-rotated box of a skew area HOT 2
- pixRead() can't read png images HOT 5
- Crash when access Pix colormap on debug HOT 6
- Installing leptonica on Windows failed with reason prompt 'SW' not found HOT 2
- Errors building Leptonica for use with Tesseract HOT 2
- getImpliedFileFormat / pixWriteImpliedFormat and PNM issues HOT 2
- pixOrientCorrect/pixOrientDetect issue with PBM HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from leptonica.