Resourcekey vs Key bug about angularlocalizationaspnetcore HOT 6 CLOSED

Hi @garfieldos I use the Key and the localizationculture as a constraint, because I assumed that it makes no sense to repeat this translation, the bank transfer is the same, just used from 2 different controllers, views.

I was thinking this would make more sense as a shared resource.

Maybe it would be better if I used the resourcekey also in the constraint, then the user of the package can decide.

If you want, I can add this, I also need to update to 1.1.

Opinion?

Greetings Damien

from angularlocalizationaspnetcore.

One key for all resource would be good, if there will be some possibility to reach this translation withot resourcekey context (without view/controller context).
Now we are using Localizer object with view/controller context and in all that contextes it should be a possibility of using this same translation keys (because their meaning could differ across different contextes).

I think, that it should be composite key on columns: Key ,ResourceKey and localizationCulture (of course sense of column name: "key" will be lost after this change)

from angularlocalizationaspnetcore.

@garfieldos makes sense, I'll make the constraint using all 3 properties. The key still makes sense for me, as this is the key without the resource.

Will update this ASAP. (also only with .NET 1.1) I want to move on from 1.0. Is this ok, or do you require the fix for .NET Core 1.0?

Greetings Damien

from angularlocalizationaspnetcore.

1.1 will be ok for me.
Thx

from angularlocalizationaspnetcore.

@garfieldos
Updated NuGet:
https://www.nuget.org/packages/Localization.SqlLocalizer/1.0.4

Code:
https://github.com/damienbod/AspNet5Localization/tree/master/AspNet5Localization/src/Localization.SqlLocalizer

from angularlocalizationaspnetcore.

Thx a lot!

from angularlocalizationaspnetcore.