pitrery list does not follow symlinks about pitrery HOT 4 CLOSED

Hello,

I did some more tests, and found that the problem is mostly due to the readlink calls on parse_target_uri() function:

• https://github.com/dalibo/pitrery/blob/master/pitrery#L344
• https://github.com/dalibo/pitrery/blob/master/pitrery#L394

These calls are always resolved locally, even if the configuration specifies that backup and archiving is done using ssh.

That could lead to other problems, like if I create a symlink on the PostgreSQL server using the same name I used ont the configuration, but linking to a directory that does not exist on the backup serveur:

-bash-4.1$ ln -s ~/other_directory/ ./my_backup_symlink

And then executes the exact same pitrery list command as before, it fails with the following error:

FATAL: could not find any backups in /var/lib/pgsql/other_directory/ on 192.168.122.72

I suppose that the readlink command should probably be called over ssh in this case, but I may be missing other factors.

from pitrery.

Hello, thanks for the investigation. I'll look into it ASAP: this looks like a tricky bug.

from pitrery.

should be fixed by 5cc31ca

from pitrery.

Hello,

I did some quick tests, and indeed it seems to be fixed:

-bash-4.1$ /opt/pitrery/pitrery list
List of backups on 192.168.122.72
/var/lib/pgsql/pitr/2018.06.04_13.19.46 13M       2018-06-04 13:19:46 CEST

Thanks again!

from pitrery.