Wrong message label when using wrong user about pitrery HOT 4 CLOSED

Hello,

Indeed, permissions are not explicitly set on backups, so one can end up with backup directories that are partly readable.

I guess the simplest way to deal with it is to make backup directories only accessible by the user who created them. This would be nice for security and would avoid spending time trying to put correct permissions everywhere.

What do you think?

from pitrery.

Well, you're absolutely right. Permissions on folders should be set so that no one except the backup creator can see them.

I don't see this recommendation in the prerequisites. Maybe you should add them.

But what I see in code seems not satisfying (to me and I might be wrong)

if [ "$out_rc" != 0 ]; then
	        echo "!!! This backup may be imcomplete or corrupted !!!"
fi

There is nothing to test permission. Whatever the error is, the message is the same and states there is corruption or incomplete backup.

from pitrery.

Commit 3888a9a restrict the permissions with a chmod 700 at backup time and a check of the permissions in list.

orgrim@serfouette:r10 $ sudo -u postgres pitrery -c r10 list
List of backups on localhost
ERROR: acces denied to /home/pgsql/pitrery/r10/2017.10.18_22.05.57
ERROR: acces denied to /home/pgsql/pitrery/r10/2018.01.08_14.32.23

Regards

from pitrery.

Perfect

from pitrery.