Code Monkey home page Code Monkey logo

Comments (7)

dahall avatar dahall commented on August 28, 2024

The parameter notes for pstReferenceTime indicate

A pointer to a SYSTEMTIME value to use as the reference date and time. A null pointer can be passed if sqro is set to SQRO_DONT_RESOLVE_DATETIME.
The 3.4.17 version couldn't allow for that so that prompted the change.

Can you help me understand more about your comment "Also unsafe code will break the IAsynEnumerable pattern."? Do you mean that you have to then have unsafe blocks? If that is the case, I can overloads that support both options in Vanara so you can just use safe code.

from vanara.

zhuxb711 avatar zhuxb711 commented on August 28, 2024

Yes, better provide a overload for that because it's not possible to create a *variable (unsafe pointer) without enabling unsafe switch for C#. For the code in 4.0.0, it's no possible to use fully safe pointer if you defined something *parameter instead of IntPtr

from vanara.

zhuxb711 avatar zhuxb711 commented on August 28, 2024

The parameter notes for pstReferenceTime indicate

A pointer to a SYSTEMTIME value to use as the reference date and time. A null pointer can be passed if sqro is set to SQRO_DONT_RESOLVE_DATETIME.

The 3.4.17 version couldn't allow for that so that prompted the change.

Can you help me understand more about your comment "Also unsafe code will break the IAsynEnumerable pattern."? Do you mean that you have to then have unsafe blocks? If that is the case, I can overloads that support both options in Vanara so you can just use safe code.

If you try to use unsafe code in a function that returns IAsyncEnumerable. You will get an error from the compiler: "Unsafe code may not appear in iterators"

from vanara.

zhuxb711 avatar zhuxb711 commented on August 28, 2024

FYR: C# Compiler Error CS1629

from vanara.

dahall avatar dahall commented on August 28, 2024

Thank you. I'll dig into this and find a resolution.

from vanara.

dahall avatar dahall commented on August 28, 2024

Fixed in 4.0.1

from vanara.

zhuxb711 avatar zhuxb711 commented on August 28, 2024

Thanks, and hope will release 4.0.1 soon~

from vanara.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.