Code Monkey home page Code Monkey logo

Comments (2)

elijahbenizzy avatar elijahbenizzy commented on July 17, 2024 1

Great, got a fix! WIll release soon. See #949.

from hamilton.

elijahbenizzy avatar elijahbenizzy commented on July 17, 2024

Thanks @legout! You've identified what appears to be a bug. I'm digging in -- first clue (+ context) is the following:

  1. The executor first breaks it up into "tasks"
  2. It then executes tasks, walking through the graph
  3. Usually this is: (1) node tasks for each of the non-parallel block tasks, then multi-node tasks for everything inside a "parallelizable block"
  4. In this case, it's not creating a task for the first one (so it never gets started). This is getting added to the middle task. It thus never reaches the end, so it just spins.

Looking into it more, hoping I can find a quick solution

Debugging information:

Tasks:

[TaskSpec(base_id='expand-numbers',
          spawning_task_base_id=None,
          nodes=[<numbers {'module': 'temporary_module_b26db111_76fe_4d83_8d44_4fc58b9542f6'}>],
          purpose=<NodeGroupPurpose.EXPAND_UNORDERED: 'expand_unordered'>,
          available_nodes={'numbers'},
          outputs_to_compute=['numbers'],
          overrides={},
          adapter=<hamilton.lifecycle.base.LifecycleAdapterSet object at 0x2a27fb810>,
          base_dependencies=['block-numbers']),
 TaskSpec(base_id='block-numbers',
          spawning_task_base_id='expand-numbers',
          nodes=[<add1 {'module': 'temporary_module_b26db111_76fe_4d83_8d44_4fc58b9542f6'}>,
                 <random_int {'module': 'temporary_module_b26db111_76fe_4d83_8d44_4fc58b9542f6'}>,
                 <add2 {'module': 'temporary_module_b26db111_76fe_4d83_8d44_4fc58b9542f6'}>],
          purpose=<NodeGroupPurpose.EXECUTE_BLOCK: 'execute_block'>,
          available_nodes={'add1', 'random_int', 'add2'},
          outputs_to_compute=['random_int', 'add2'],
          overrides={},
          adapter=<hamilton.lifecycle.base.LifecycleAdapterSet object at 0x2a27fb810>,
          base_dependencies=['expand-numbers']),
 TaskSpec(base_id='collect-numbers',
          spawning_task_base_id='expand-numbers',
          nodes=[<collect_numbers {'module': 'temporary_module_b26db111_76fe_4d83_8d44_4fc58b9542f6'}>],
          purpose=<NodeGroupPurpose.GATHER: 'gather'>,
          available_nodes={'collect_numbers'},
          outputs_to_compute=['collect_numbers'],
          overrides={},
          adapter=<hamilton.lifecycle.base.LifecycleAdapterSet object at 0x2a27fb810>,
          base_dependencies=['block-numbers'])]

from hamilton.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.