Work with require.js in browser about dagre-d3 HOT 7 CLOSED

I've also run into this attempting to integrate DagreD3 into an iPython notebook. D3 no longer exports the d3 global in the presence of an APM framework (d3/d3#1693). iPython manages dependencies through requirejs so this is a problem. It is meant to be possible to solve the problem using an approach similar to @pats, except you don't need to shim D3.

So I expected to be able to do this:

require.config({
    paths: {
        'd3': 'd3.min',
        'dagre-d3': 'dagre-d3'
    },
    shim: {
        'dagre-d3': {
            deps: ["d3"],
            exports: 'dagreD3'
        }
   }
});

// then use require or define

Unfortunately this doesn't work. I am a bit a noob regarding the bower stuff and I have managed to work around this with a fairly ugly hack, but is there any recommended way you would solve this problem?

Regards,
Brendon

from dagre-d3.

I don't have any experience with bower, but I'm open to someone contributing the required changes to enable it. It looks like someone did some work to enable bower with dagre here: https://github.com/passelin/dagre. Maybe it can be used as a starting point for dagre-d3?

from dagre-d3.

Chris, thanks for responding. I don't really know what I'm talking about with Bower as I've never used it. If I get some headspace, I'll try and dig into what you're doing, what Bower is, and how to solve this issue.

from dagre-d3.

I think it's the issue CommonJS vs. AMD (browserify vs. requrejs). Check this build of dagre-d3 https://github.com/andrvb/dagre-d3-umd.

from dagre-d3.

@andrvb Thanks so much! Completely solved the problem.

from dagre-d3.

@andrvb - thanks for doing this. Is this something that we can fold back into the dagre-d3 build?

from dagre-d3.

I think it is. You just have to do a bit of boilerplate that detects whether you're bring loaded in a place that already exposes a requirejs install. If so, just require('d3') which should allow maximum flexibility in allowing the embedder to specify what 'd3' means to them (that is an absolute url to a cdn, or to a local version.)

Edit: That boilerplate is here: https://github.com/andrvb/dagre-d3-umd/blob/master/dagre-d3.js#L2

from dagre-d3.