Environment variables logic is error prone (for windows particularly) about reproc HOT 2 CLOSED

Hi,

Thanks for creating the issue! In hindsight, it's indeed a lot more intuitive to extend the parent environment with extra environment variables instead of replacing it. The latest commit on master modifies the environment option a bit (which is now named env). It now takes a behavior argument which allows the user to indicate whether he wants to extend the parent environment or start from scratch with an empty environment. By default, the parent environment is extended. Extra environment variables are added via env.extra.

Usage:

reproc::options options;
options.env.behavior = reproc::env::extend;
options.env.extra = std::unordered_map<std::string, std::string> { { "MESSAGE", "EXTEND"} };

Does this fix the issue for you? Any feedback would be welcome and appreciated.

from reproc.

Hi,
Thanks very much for the quick respond and change. That's some reactivity right here ^^
I like the new interface it's clean 👍 !
I close the issue

from reproc.