Comments (7)
For the libsodium.js
dependency, progress is here: cosmos/cosmjs#904
For the bip39
dependency, I think we can handle that on our side with a bit better optimization. A good static analyzer should be capable of removing it. It's just a regular (i.e., js, non-compiled) dependency of cosmjs/crypto: https://github.com/cosmos/cosmjs/blob/main/packages/crypto/package.json#L47
from dao-dao-ui.
I wonder why libsodium.js isn't optimized out entirely. In thise codebase you use none of its functionality. However, I'm not aware of state of the art in JS optimization.
from dao-dao-ui.
I have the same question @webmaster128. I think whatever the next build
optimizer does is just not up to snuff---reasonable tree-shaking should get rid of the dependency. (libsodium.js size is still an issue, but shouldn't be our issue).
from dao-dao-ui.
Jupp. I found a pretty good explanation in gcanti/fp-ts#813 and gcanti/fp-ts#814 for what needs to be done in CosmJS to make this work.
from dao-dao-ui.
I think this is a "Won't Fix" because it's upstream. Closing for now.
from dao-dao-ui.
Re-opening this issue, as there is some hope of trimming the bundle sizes by removing dependencies on libsodium and bip39 using the tricks described here: cosmos/cosmjs#904 (comment)
from dao-dao-ui.
fixed in cosmjs v0.28 - just need to upgrade the package
from dao-dao-ui.
Related Issues (20)
- Add relay transaction button to profile actions page
- Existing token existence not validated
- Unexpected end of JSON input on Osmosis DAO creation HOT 1
- Overflow in LP token balances
- Show more following DAOs in sidebar HOT 1
- Prompt to create a Polytone account when using an Interchain App (if the DAO doesn't have one)
- Move proposal creation draft URL to cloud HOT 1
- Indicating content availability in the scroller
- Bug: Create DAO action as a DAO proposal HOT 1
- Bug: Create SubDAO proposal doesn't set the admin HOT 3
- UI is not updating transferred vesting payments
- home feed proposal navigation multiple chains HOT 1
- props need interaction indicator HOT 1
- Socials tab - feature request
- Retroactive Compensation updates for Regen
- Inaccurate migrate warning
- New Feature: display predictable contract address during Instantiate2
- Profile pic upload modal incorrectly placed behind Logged in confirmation modal
- Retroactive Compensation only works on the DAOs native chain
- Better message editor
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dao-dao-ui.