Comments (3)
Are we getting rid of the d3.geo namespace in v4 and just appending "geo" to the names of its members?
Yes. For example, d3.geo.stream becomes d3.geoStream. ES6 modules export symbols, so a flat namespace is required.
Do you have any sort of style guide or list of conventions that you use in the d3 codebase?
No, sorry. You’ll have to look at the other repositories to infer the style conventions…
I'm also guessing that you have plans for d3-geo beyond simply breaking it out into its own module.
Yes, but they are probably going to wait until D3 5.0 since I’d like to get D3 4.0 released. The primary idea I’d been pursuing is a modular projection pipeline (example 1, example 2, example 3), rather than our current monolithic projection pipeline. There are a couple optimizations of rotation and clipping in the current pipeline that might be hard to replicate with the modular pipeline (see #2169), but I’m not sure it’s a showstopper.
from d3-geo.
Hey! I'm the guy who expressed interest in helping on Twitter the other night. I'm currently in the process of clearing the Contributor Agreement with my employer (hopefully should be good sometime next week).
In the meantime, I've got a couple questions about how best to help:
- Are we getting rid of the
d3.geo
namespace in v4 and just appending "geo" to the names of its members? - Do you have any sort of style guide or list of conventions that you use in the d3 codebase? I've looked at d3-selection as an example to follow, but I wasn't sure if you had an actual guide written down somewhere.
- I'm guessing that a lot of the initial work of this project will involve copying over code (and docs) from d3 and getting the code and tests into line with the tools and conventions you're using in v4. However, I'm also guessing that you have plans for d3-geo beyond simply breaking it out into its own module. Do you have any initial notes or ideas that could guide me while working on this?
I've used d3.geo
in a number of projects, I'm looking forward to giving back to this awesome library!
from d3-geo.
Fixed in #9.
from d3-geo.
Related Issues (20)
- d3.geoBounds returning confusing output HOT 1
- How can I clamp a geodesic to between a max/min latitude? HOT 1
- fit-test.js Remove duplicate test HOT 1
- Geojson to SVG offset HOT 1
- Geojson to SVG offset
- Cannot import d3-geo in node with typescript HOT 8
- Geographic or Geodetic HOT 1
- D3 uses GeoJSON to represent geographic features in JavaScript HOT 2
- postclip with polygon path maybe... HOT 10
- Error [ERR_REQUIRE_ESM]: Must use import to load ES Module / require() of ES modules is not supported HOT 2
- geoAzimuthalEqualArea not rendering straight lines HOT 2
- clipCircle's precision is too low
- Configurable precision for d3.geoPath
- Mercator. Getting boundary values by longitude HOT 2
- Mercator with rotate. Incorrect conversion from projection to geographic coordinates HOT 3
- Сonvert geographic points considering antimeridian and pole HOT 1
- geoContains function doesn't seem to handle MultiPolygons HOT 9
- path.bounds should return numbers even when input coordinates are strings
- [Question] API for chekcing if point is in view or not given projection HOT 3
- Mercator Map centered on the Pacific HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from d3-geo.