Comments (6)
Yes!
from d3-dsv.
I'm not totally sure of the consequences here, isn't it that we can now inline objectConverter?
from d3-dsv.
I simply added f=autoType to parse and parseRows, and got 77 test failing π± β I started to go through them, but for so many of them, I'm at a loss whether we want to change them or keep the old test with f=null
or f = identity
.
Examples:
tape("csvParse(string) does not strip whitespace", function(test) {
test.deepEqual(dsv.csvParse("a,b,c\n 1, 2 ,3 "), table([{a: " 1", b: " 2 ", c: "3 "}], ["a", "b", "c"]));
test.end();
});
autoType returns numbers 1, 2, 3.
We could amend the test to "csvParse(string, null) does not strip whitespace"; or test that we get 1, 2, 3. (There is an autoType test saying it should return a number.)
tape("csvParse(string) treats empty fields as the empty string", function(test) {
test.deepEqual(dsv.csvParse("a,b,c\n1,,3"), table([{a: 1, b: "", c: 3}], ["a", "b", "c"]));
test.end();
});
autoType returns b:null
etc.
from d3-dsv.
Iβm not inclined to change this behavior for d3 v6, because even though it might be nice, itβs a pretty significant backwards-incompatibility shift.
from d3-dsv.
from d3-dsv.
Iβm inclined to keep the status quo for the foreseeable future.
from d3-dsv.
Related Issues (20)
- csv2json cli throws error when using --auto-type
- Add shoutout to d3.autoType in d3.parse documentation
- TypeError: Cannot read property 'trim' of undefined HOT 3
- dsv.parse's returned columns property doesn't reflect row conversion function HOT 4
- Use Object.fromEntries to convert arrays into objects? HOT 1
- date tests fail HOT 2
- Export individual "formatRow" and "formatValue" functions HOT 5
- Avoid "Function" constructor HOT 1
- Add documentation about CSP incompatibility HOT 1
- Could we possibly add a ssv() or wssv()? HOT 4
- [RFC] Split out the CLI to a separate package HOT 3
- Repeated columns names erase each other for xParse HOT 6
- wrong parsing d3.tsvParse with only number header HOT 4
- d3.autotype: keep leading 0 HOT 1
- Option to quote empty strings? HOT 1
- Error: Must use import to load ES Module HOT 4
- Potential performance issue - Columns property added to returned array from dsv.parse could lose browser engine optimization on array operations HOT 1
- Column data will be lost if the column name is the same HOT 1
- `objectConverter` can work without `Function`. HOT 1
- https://observablehq.com/@mbostock/streaming-csv HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from d3-dsv.