Code Monkey home page Code Monkey logo

Comments (7)

dotasek avatar dotasek commented on July 17, 2024

I noticed that the string app is included in the Swagger table. It might be wise to limit the scope of py2cytoscape to the Cytoscape API and its Core Apps even in the docs.

from py2cytoscape.

jorgeboucas avatar jorgeboucas commented on July 17, 2024

that is definitely a good point.

We should reflect a bit on this:

  • A) would we then push towards a self contained packaged (with py2cytoscape as dependency) for every non core app? In this case we can use the String App as a show case.

  • B) otherwise we could have it like for core Apps. i.e. cyrest/string.py with the respective class and functions inside and then something like a def string() in the cyclient class in cyrest/cyrest.py. Given it would stay fixed to one contained file cyrest/string.py and a section in cyrest/cyrest.py it would still be easy to both develop and deprecate when required.

For option B it would be important to make sure Apps are enclosed as described for the String App. On the long run B would clearly demand more work from a package maintenance side but also make the package more complete and probably enforce proper and continuous maintenance of all the python interface for non-core apps.

I would vote for B but I am probably biased as that was my initial intention.

(ps. I added the link to the table which I initially forgot - sorry for that)

from py2cytoscape.

bdemchak avatar bdemchak commented on July 17, 2024

from py2cytoscape.

jorgeboucas avatar jorgeboucas commented on July 17, 2024

40 apps at 2 to 40 functions per App feels a bit out of the range to me.

I will give it a try at how String as a separate package would look like before I continue with the rest.

Sounds good?

Do we have a guideline we would like to set for such packages - eg. py2cyString ?

from py2cytoscape.

dotasek avatar dotasek commented on July 17, 2024

We've already gotten official submissions for about 20 apps, as of the last time Barry spoke to me about it, so I don't think 40 apps is out of range. It's our hope that the number will continue to grow.

I'm all for creating String as a separate package. Diffusion, one of the apps we regularly use as an example, has some python associated with it for test purposes. After taking a look at how String would look as a package we could make this test code more usable as general python.

py2cyWhateverApp sounds fine as a naming guideline.

from py2cytoscape.

jorgeboucas avatar jorgeboucas commented on July 17, 2024

👍

  • I meant out of range for being centrally maintained inside py2cytoscape

I will go for it then - let me know if there are more Apps in the compliance table that don't belong in "Core Apps"

from py2cytoscape.

jorgeboucas avatar jorgeboucas commented on July 17, 2024

all swagger calls have been ported since ff2802c

from py2cytoscape.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.