Comments (5)
In the case of JSON, the key is a string, so JSON itself may be a snake_case expression; in the case of MemoryPack, it's only C# to C#, so other languages and such don't really matter I think.
Maybe you want to convert JSON -> C# -> MemoryPack. But even in that case, it seems to me that deserializing the JSON in snake_case to C# in camelCase would solve the problem.
If we support snake_case, we may need to support everything, including kebab cases. This would be complicated. We have decided to not to implemented it.
If you can point us to an important use case, we would welcome it. Thanks.
from memorypack.
Is there a strong reason why you want to use snake_case?
Generally it is not recommended.
from memorypack.
Is there a strong reason why you want to use snake_case?
Generally it is not recommended.
There are many different coding styles. Snake case is common in Ruby, and it works in Newtonsoft.Json.
from memorypack.
@hadashiA I think this issue should not have been closed. Constructors already support variables starting with an underscore, so the PR only extends the functionality by ignoring underscores completely. I use snake_case
in constructors to differentiate from fields as a matter of preference. As for kebab case, C# identifiers don't support kebab case. I don't see a reason to reject the PR.
from memorypack.
Using snake_case
in constructors is not common practice.
There is no need to add extra support just for that naming convention.
from memorypack.
Related Issues (20)
- AcessViolationException from MemoryPackReader.ReadString HOT 3
- Nested types support HOT 1
- ArrayTypeMismatchException: when using collections with interfaces HOT 1
- Nullable Float and Double values are serialized incorrectly by the TypeScript serializer methods. HOT 1
- [Request] Error with parameters in class that are not Deserialized
- TypeScript generator is generating files with mixed line endings
- Memory<T> support for TypeScript generator
- TypeScript generator is a bit too eager to generate the file HOT 1
- Support Orleans HOT 1
- Compilation errors on Unity 2022.3.36f1 when adding v1.21.1 to package.json HOT 1
- C# Multiple inheritance types lost on Serialization/Deserialization HOT 2
- Is there anything like a non-generic IMemoryPackable? HOT 1
- Error Occured in Quick Start case HOT 1
- Proposal: Replace 'in' with 'ref' in Serialize method when using TBufferWriter HOT 1
- Init-only property in CircularReference class is not Deserialized HOT 1
- Unity console log file links do not navigate to generated files HOT 1
- SortedList<long,float?> and SortedList<long,double?> Deserializes incorrectly HOT 1
- [MemoryPackIgnore] for field in unmanaged struct does not wok. HOT 1
- [SuppressDefaultInitialization] for field in TypeScript does not wok. HOT 1
- Make GenerateTypeScript support GenerateType.VersionTolerant HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from memorypack.