Code Monkey home page Code Monkey logo

Comments (9)

cyrilis avatar cyrilis commented on July 20, 2024 5

Hi @pedrosanta ,
I think porting to ES6 or Typescript is becoming more and more necessary. I agree to abandon CoffeeScript too (which is one of top 3 most dreaded language in stackoverflow 2018 survey ).

And porting to ES6 or Typescript is also a good change to refactoring some old/abandoned code, and I'm learning ES6 too. πŸ˜‰

Cheers, let's do this. πŸ€–

from epub-gen.

cyrilis avatar cyrilis commented on July 20, 2024 1

from epub-gen.

actuallymentor avatar actuallymentor commented on July 20, 2024 1

+1 for ES6.

It would also make it easier for people like me to contribute more frequently to the repo.

from epub-gen.

mikecook avatar mikecook commented on July 20, 2024 1

I'll just leave this here in case you hadn't seen it: https://github.com/decaffeinate/decaffeinate

from epub-gen.

gcoda avatar gcoda commented on July 20, 2024 1

@emagnier it took less than hour to convert this to typescript, with help of decaffeinate, and few simple types, since ES6 is still valid TypeScript you can cut some corners and disable some of default checks.

check commits from my fork, gcoda/epub-gen.
i will be glad to do it all over again, since i modified a lot of code for my needs without really digging in the logic.

from epub-gen.

pedrosanta avatar pedrosanta commented on July 20, 2024

Great @cyrilis!

So, if you don't have a strong opinion between those two, I would lean to migrate to ES6 at the moment (which will already allow us to upgrade the code/syntax by a lot) – and if we feel the need later, upgrade to TypeScript.

Sounds fair?

from epub-gen.

gcoda avatar gcoda commented on July 20, 2024

@cyrilis i just converted it to typescript, without reading code first. πŸ˜•
I did a bad job, but with "strict": true option.
forked repo
Looks like it works, most likely something broke, but with some understanding of internals i will do some refactoring of my mess πŸ˜‰

Edit: type definitions might be helpfull with current build

Screenshot-20200405020008-732x500

from epub-gen.

bmccann36 avatar bmccann36 commented on July 20, 2024

πŸ‘ for typescript

from epub-gen.

emagnier avatar emagnier commented on July 20, 2024

On my side, I'm definitely in favor of TypeScript.
It will probably be a little more work to add typing, but I think it's worth it, because this will bring a lot more robust codebase for sure!

However moving first to ES6 could be a first step before going on TS.

from epub-gen.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.