Code Monkey home page Code Monkey logo

Comments (3)

pedrosanta avatar pedrosanta commented on July 2, 2024 1

Nice catch @alecgibson. 👍 Yep, I say strip the query string from the image URL, and then mime would work well, I suppose. I can put up a PR, along with another one for #52, as soon as possible.

from epub-gen.

pedrosanta avatar pedrosanta commented on July 2, 2024

It would be best if epub-gen stripped the query string when trying to determine the mediaType and extension.

Yep, just checked out on mime package and it really doesn't support URL with query strings (check broofa/mime#131)(1), so, agreed, better to update the lib to remove/ignore the query string before checking the mime types/extension.

Coming right up!

(1) - The mime lib seems more oriented to file paths and all, and author prefers that responsibility to lie outside the mime lib so, no point raising an issue there/upstream I suppose. 🙂

from epub-gen.

pedrosanta avatar pedrosanta commented on July 2, 2024

Fixed on v0.0.19. Closing.

from epub-gen.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.