Code Monkey home page Code Monkey logo

Comments (3)

pedrosanta avatar pedrosanta commented on July 20, 2024 1

Hey @alecgibson, that totally makes sense, I'll put up a PR with it. 👍

from epub-gen.

alecgibson avatar alecgibson commented on July 20, 2024 1

Yeah, didn't know we had that option! Makes sense. Happy to close this.

from epub-gen.

pedrosanta avatar pedrosanta commented on July 20, 2024

Hi @alecgibson, so I've been looking to the code and how it is, might be tricky to provide that on Promise resolution, because at that point the TOC is already generated (file zipped and all) – isn't ringing as optimal to me, idk.

How about a different approach, along these lines:
- allow the lib users to provide their own optional slugs for contents – as a content.slug option for instance, we'll add and document that;
- this way it is the user responsibility to truncate the slugs (used for filenames too) as they deem fit(1);

(1) I'm stating this one, because I'm thinking that each user/project will have their files/folders in different depths/path sizes on each system and path/filename sizes might be dependent of each environment, hence giving that option to lib users. IDK, does this make sense? 🤔

EDIT: Just noticed one can use an optional content.filename on each content, wouldn't this work out to mitigate this error? (I think the slug it's also mainly used to build the filename, so...)

Stating this, because I'm thinking that each user/project will have their files/folders in different depths/path sizes on each system thus path/filename sizes might be dependent of each environment, hence could be something to lie upon the lib users/projects to tweak out in this case? IDK, does this make sense? 🤔

from epub-gen.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.