`cyctl`: implement a create method for Modules about cyclops HOT 7 OPEN

Hey @siddhantprateek, sorry for the delay, I forgot to respond. Yeah, this looks good, except that I would leave out values from the file, but all the other parts look good!

No issues, i was working on cerbos authorization part until that, i'll update the suggested changes for this

from cyclops.

@petar-cvit, I've implemented a command for creating TemplateStore custom resources:

cyctl create template NAME --repo='https://github.com/cyclops-ui/templates' --path='/path' --version='main'

I’m considering adding namespace flags as well.

Currently, the --version flag defaults to main.

What are your thoughts on this?

from cyclops.

Nice! The version flag does not need to default to anything. There is already logic for defaulting when the version is not specified in the controller, so a template without a version is completely valid.

Can you split this issue into multiple smaller ones since Module creation could be a bigger chunk of work then the creation TemplateStore CR? You can open a new issue for the creation of templates and I can assign you to it

from cyclops.

I was wondering if we could have a command like,

cyctl create module NAME -f values.yaml

since the values are not consistent.

from cyclops.

you are thinking about values.yaml containing only the values or the whole Module? If its just the values, you need to add flags for template reference

from cyclops.

the values.yaml will contain this

  values:
    general:
      environment:
        ENVIRONMENT: production
      image: nginx
      version: 1.14.2
    name: nginx-app
    networking:
      expose: true
      port: 8080
    scaling:
      replicas: 2
      resources:
        cpu: 0.1
        memory: 0.01

and the complete command would look something like this

cyctl create module NAME -f values.yaml \ 
--repo 'github.com/github/demo' \
--path '/path/to/charts' \
--version 'main'

from cyclops.

Hey @siddhantprateek, sorry for the delay, I forgot to respond. Yeah, this looks good, except that I would leave out values from the file, but all the other parts look good!

from cyclops.