Example of using signal_conditioner with shared_ptr about q HOT 4 CLOSED

Show me the code that does not work.

from q.

q::decibel(q::detail::db2a(m_threshold))));

BTW, this does not look good. detail is private and should not be used by clients. Also, why are m_lowestPitch and m_highestPitch not q::frequency types? While this works, it is subverting the strict type system, like using void*.

I know, I know... off-topic... I just can't resist advocating good modern c++ usage :-)

from q.

😅 I'll try to tidy up the code a bit - some things are a hangover from when I was figuring things out.

Code that doesn't work:

// in header
std::shared_ptr<cycfi::q::signal_conditioner> m_pp;

// in initializer
...
auto m_pp = std::shared_ptr<cycfi::q::pitch_detector>(new cycfi::q::pitch_detector(
			    q::frequency(m_lowestPitch),
			    q::frequency(m_highestPitch),
			    m_inputSampleRate,
			    q::decibel(q::detail::db2a(m_threshold))));

...

// inside process function
float s = m_pp->operator(inputBuffers[0][i]);

It compiles but with a note:

QlibPitch.cpp:277:21: note: in instantiation of function template specialization 'cycfi::q::signal_conditioner::signal_conditioner<cycfi::q::signal_conditioner::config>' requested here
    auto sig_cond = cycfi::q::signal_conditioner(

and then segfaults when I try to run it. I 100% expect this to be an issue with my code - I'm mainly just trying to understand how to share an instance of the signal conditioner across several different function calls.

from q.

// in initializer
...
auto m_pp = std::shared_ptrcycfi::q::pitch_detector(new cycfi::q::pitch_detector(
q::frequency(m_lowestPitch),
q::frequency(m_highestPitch),
m_inputSampleRate,
q::decibel(q::detail::db2a(m_threshold))));

This does not make sense. m_pp is a std::shared_ptr<cycfi::q::signal_conditioner> and you are assigning a std::shared_ptr<cycfi::q::pitch_detector> to it?

from q.