cybercraftinc / vacation_system Goto Github PK

Please move "sign out" button to the right because I have already clicked on it to times while moving forward menu tabs...

As a user I want to be able to cancel requested, accepted vacations with notification of this event to manager by mail or any other way. Vacation Should be listed in cancelled list.

The administrator role should provide the following privileges:

• to create teams;
• to remove empty teams;
• to create a user;
• to update all the user information, except password;
• to invite new users;
• to add users to teams;
• to remove users from teams;
• to add holidays;
• to update holidays;
• to remove holidays.

Holidays must be shown in Vacations Time Table panel.

As a user I want to see list of vacations collapsed by default and it should expand on click. List of vacation should be listed in table with filter (please see example https://www.datatables.net/)

As a user I would like to be informed about any events that are triggered in response to my input.
For example, I would like to see an error notification when I supplied a form with invalid data.

The VacationRequest#cannot_intersect_with_other_vacations can be implemented in more simple way, as follows:

(start_date - another.end_date) * (another.start_date - end_date) >= 0

But in SQL 😉

As an administrator I want to be able to import list of users from a CSV-file.
Let's say, the following command should do the job:

rake users:import_from_csv

The UI layout is rendered as follows:

The following error appears in JS console:

TypeError: this.availableVacations.findWhere(...) is undefined

As a user I want to see the calculated duration for the requested vacation on Dashboard.

• add yml file with ukranian language
• replace all ukrainian words in the code with I18n keys

As a user with manager role I want to see the calculated duration for the requested vacation on Dashboard.

As a user I want to see duration of all my vacations when I visit Vacations page.

Needs some info in Readme file how setup and start project on fresh system.

There are changes in Labor Code of Ukraine.
The application should deal with those changes.

As a user I want to see who has approved my request and who still pending

Manager should be able to see how many vacation days left to decide if user can go to vacation or not

Please remove empty brackets from menu when user is not sign in

As a user I want to use a button for particular action.
In case of Holidays page, I want to click UPDATE button to edit a holiday, rather than mouse double click on a row. Furthermore, the latter is not obvious for new users.

The Vacations page, #/vacations, should contain a section with the following vacations related summary for the user:

• number of requested days for a year;
• number of used days for a year;
• number of accumulated days for a year;

A new section title should be the Planned Vacation Summary.

As a user I want to change data in forms with a unified UI component.

Vacation visualization in Vacations Time Table panel, on Dashboard page, fails to show vacations properly.
For example, vacation for two days may be shown or may be not.
And it seems that vacation for one day is not shown at all.

Avoid using hardcoded statuses values, like following:

if (row.status === 'cancelled')

The following approach should be used:

if (row.status === App.Vacation.statuses.calcelled)

A holiday must be unique by it's date and description, that is, start and description fields.
This will allow to create many holidays with the same name but with different dates.

Extract common state and behaviour into a base class, and extend it with specific ones.

As a user I would like to see all my used vacations.

When a holiday has its duration greater than one day, it is marked as a one-day holiday, by start day.
It must be changed so that all the days of holiday are marked properly.

When I click "request" on /vacation_requests page - I should see my requseted vacation at bottom.

This must be a privilege of a user with the admin role.

The employment_date field is used in calculation of available vacation days. It is mandatory to have this field filled in correctly.

Let's say, we have the following user:

rake users:list_as_json
...
{"id":1,"first_name":"Tony","last_name":"Shark", ... , "employment_date":"2015-01-12"}
...

And we'd like to update user related data:

rake users:import_from_csv
...
UPDATED Tony Stark
...

As a result we expect to see the user's last_name as Stark, not Shark:

rake users:list_as_json
...
{"id":1,"first_name":"Tony","last_name":"Shark", ... , "employment_date":"2015-01-12"}
...

But still get an old value. The reason might be in validation error happening during update.

The view does not render list of vacation requests.

As a user I want to request vacations before 2015-01-01.
New possible start date should be at least 2013-09-01.

As a user I want to see my full name against related row in Time Table.

The header breaks into two lines with breaking layout when there are few days in a month to be displayed. See the following picture:

As a result, the list of users mismatches corresponding rows in table, as shown in the following picture:

The first user in the list corresponds to the days, not user's row in the table.

There is a need to play with functionality, where there is a team with more than one manager.
I wonder if a new member should be a woman. 😉

As a user I expect a confirmation dialog on a holiday delete action.

How to reproduce

1. Open vacation requests page
2. Request new vacation
3. Switch filter to show vacation requests with status requested
4. Verify that vacation request is created properly
5. Request another vacation for another period
6. Verify that previous vacation request type is changed
7. Verify that no vacation request is added

As I CyberCraft Vacation user I should be able to see only login page if I wasn't logged in before.

Rename column planned_end_date into end_date, and remove actual_end_date.

The problem appears in Webkit based browsers, which implement inputs of type date.
The same issue exists in FF despite its lack of date inputs support.