Comments (8)
@Cyan4973 First off, thank you for the very prompt responses. Given what you've said, I am happy to include this very cool work in awesome-c, as it really seems that this issue is a corner case that people wouldn't encounter casually.
from finitestateentropy.
Thanks for the clear reproduction case @Makush .
I'll look into it.
from finitestateentropy.
Is this still an issue?
from finitestateentropy.
Yes it's still an issue.
Huge alphabet size is a fairly specific use case, I don't have any real-world situation where it applies.
But it's nonetheless something to fix.
from finitestateentropy.
@Cyan4973 The main reason I ask is because I maintain awesome-c, and I would like to include your work, but this issue has me concerned.
from finitestateentropy.
The issue still needs to be fixed.
So I need to find some time to do it.
But I wouldn't be that concerned by it.
I'm keeping the bug opened to not forget it, but really, you have to go through some uncommon scenario and invoke a rare interface labelled "experimental" which is not even present in fse.h
, plus an additional set of conditions on distributions (which basically means FSE is not the right tool for the task) to have a chance to trigger it.
from finitestateentropy.
FYI, I believe that this might be fixed in the zstd code with the addition of:
if (ToDistribute == 0)
return 0
commit: facebook/zstd@9889bca#diff-27457e92342bf0494cfc4a4ad6ba6bc9
I was able to repro this with another use case and I've fixed it with the addition of that if statement. Unfortunately I don't have my repro code anymore.
from finitestateentropy.
@yohan1234 That code was pulled in here at ea7b345
Perhaps this is no longer an issue now.
from finitestateentropy.
Related Issues (20)
- resync with changes from zstd HOT 2
- Crash when FSE_MAX_MEMORY_USAGE 13 HOT 6
- benchmark mode claims a decompression error on this data w/huf HOT 5
- question: FSE doesn't always compress better than huf - expected? HOT 2
- how to start? and how to use the Huffman codec?
- a step in normalization of count HOT 2
- How should we understand this function ‘FSE_normalizeM2’? HOT 2
- Why Huffman code in reverse order? HOT 2
- FSEU16_MAX_MEMORY_USAGE is defined at fseU16.c not a fseU16.h
- FSE performance optimizations HOT 3
- Negative index into stateTable? HOT 1
- FSE_isError and FSE_getErrorName HOT 1
- Inconsistencies in stream format HOT 1
- Decoding error : Destination buffer is too small HOT 2
- huff0 with > 256 symbols HOT 7
- Error 39 : Decoding error : Destination buffer is too small HOT 1
- FSE_compress returns 0 even when maxDstSize is still equal to or slightly larger than final compression size HOT 3
- Corrupted block detected error reported in -hb mode HOT 3
- NULL pointer dereference in BIT_reloadDStream() HOT 7
- FSE_compressU16() computes clipped data if dstCapacity different HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from finitestateentropy.