The default player 1 controls (up, down, left, right), also control the menus of the s

Player 1 controls can affect other players in character selection about cdogs-sdl HOT 1 CLOSED

Kurtsley commented on July 21, 2024

Player 1 controls can affect other players in character selection

from cdogs-sdl.

Comments (1)

Kurtsley commented on July 21, 2024

I think I've found the cause of this issue and would like some feedback.

It looks like this is the block of code responsible for the player selection menu input:

cdogs-sdl/src/prep.c

Lines 410 to 440 in fbac574

    
           // Menu input 
        
           int idx = 0; 
        
           const bool useMenuCmd = GetNumPlayers(PLAYER_ANY, true, true); 
        
           for (int i = 0; i < (int)gPlayerDatas.size; i++, idx++) 
        
           { 
        
           	const PlayerData *p = CArrayGet(&gPlayerDatas, i); 
        
           	if (!p->IsLocal) 
        
           	{ 
        
           		idx--; 
        
           		continue; 
        
           	} 
        
           	if (p->inputDevice != INPUT_DEVICE_UNSET) 
        
           	{ 
        
           		MenuSystem *ms = &pData->menus[idx].ms; 
        
           		if (ms->current->customPostUpdateFunc) 
        
           		{ 
        
           			ms->current->customPostUpdateFunc( 
        
           				ms->current, ms->current->customPostUpdateData); 
        
           		} 
        
           		MenuUpdateMouse(ms); 
        
           		if (useMenuCmd) 
        
           		{ 
        
           			cmds[idx] |= 
        
           				GetMenuCmd(&gEventHandlers, ms->current->mouseHover); 
        
           		} 
        
           		if (!MenuIsExit(ms) && cmds[idx]) 
        
           		{ 
        
           			MenuProcessCmd(ms, cmds[idx]); 
        
           		} 
        
           	} 
        
           }

When player one pressed Up for example, the command was sent twice which ended up affecting the second player. I believe this is caused by the GetMenuCmd function at line 433. The input for this menu is processed at line 437 if there has not been an exit command.

Why does this block get called as well?

cdogs-sdl/src/prep.c

Lines 430 to 434 in fbac574

    
           if (useMenuCmd) 
        
           { 
        
           	cmds[idx] |= 
        
           		GetMenuCmd(&gEventHandlers, ms->current->mouseHover); 
        
           }

It looks like useMenuCmd checks if there are any local, alive players. If that is the case, process their key presses. GetMenuCmd and MenuProcessCmd both process the player 1 key presses. More specifically, it looks like GetMenuCmd controls both player menus in the player selection screen.

TLDR removing the above block which calls GetMenuCmd along with the useMenuCmd check fixes this issue.

from cdogs-sdl.

Recommend Projects

Player 1 controls can affect other players in character selection about cdogs-sdl HOT 1 CLOSED

Comments (1)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	// Menu input
	int idx = 0;
	const bool useMenuCmd = GetNumPlayers(PLAYER_ANY, true, true);
	for (int i = 0; i < (int)gPlayerDatas.size; i++, idx++)
	{
	const PlayerData *p = CArrayGet(&gPlayerDatas, i);
	if (!p->IsLocal)
	{
	idx--;
	continue;
	}
	if (p->inputDevice != INPUT_DEVICE_UNSET)
	{
	MenuSystem *ms = &pData->menus[idx].ms;
	if (ms->current->customPostUpdateFunc)
	{
	ms->current->customPostUpdateFunc(
	ms->current, ms->current->customPostUpdateData);
	}
	MenuUpdateMouse(ms);
	if (useMenuCmd)
	{
	cmds[idx] \|=
	GetMenuCmd(&gEventHandlers, ms->current->mouseHover);
	}
	if (!MenuIsExit(ms) && cmds[idx])
	{
	MenuProcessCmd(ms, cmds[idx]);
	}
	}
	}