Code Monkey home page Code Monkey logo

Comments (8)

cwilso avatar cwilso commented on July 23, 2024

I'd need to debug. A-880 pitch of what?

from pitchdetect.

hellofishy avatar hellofishy commented on July 23, 2024

Of a test oscillator so it should be exact. It works for 220 and 440. But
random notes in the scales don't work. For example the E below 440
corresponds to a sharp C. This is true with many pitches

On Tue, Jul 1, 2014 at 4:01 PM, Chris Wilson [email protected]
wrote:

I'd need to debug. A-880 pitch of what?


Reply to this email directly or view it on GitHub
#5 (comment).

from pitchdetect.

hellofishy avatar hellofishy commented on July 23, 2024

Let me know if you figure it out, really good work though!

On Tue, Jul 1, 2014 at 4:13 PM, Zack Cohen [email protected] wrote:

Of a test oscillator so it should be exact. It works for 220 and 440.
But random notes in the scales don't work. For example the E below 440
corresponds to a sharp C. This is true with many pitches

On Tue, Jul 1, 2014 at 4:01 PM, Chris Wilson [email protected]
wrote:

I'd need to debug. A-880 pitch of what?


Reply to this email directly or view it on GitHub
#5 (comment).

from pitchdetect.

cwilso avatar cwilso commented on July 23, 2024

OK, that should fix it. There was some crosstalk with further copies of the waveform, particularly when the waveform EXACTLY matched (modulo aliasing). Should work much better now. Also redeployed to webaudiodemos.appspot.com.

from pitchdetect.

hellofishy avatar hellofishy commented on July 23, 2024

Great! It works a ton better. Still seems to be a few cents off. 440A
reads as 441hz and 3cents off. 880A reads 882hz with 3 cents off aswell.
Each note seems to be a few cents off. I don' t know if the algorithm you
use is an approximation one but just letting you know.

On Tue, Jul 1, 2014 at 6:37 PM, Chris Wilson [email protected]
wrote:

OK, that should fix it. There was some crosstalk with further copies of
the waveform, particularly when the waveform EXACTLY matched (modulo
aliasing). Should work much better now. Also redeployed to
webaudiodemos.appspot.com.


Reply to this email directly or view it on GitHub
#5 (comment).

from pitchdetect.

hellofishy avatar hellofishy commented on July 23, 2024

Im running a test oscillator through so it should be exact

On Wed, Jul 2, 2014 at 10:26 AM, Zack Cohen [email protected] wrote:

Great! It works a ton better. Still seems to be a few cents off. 440A
reads as 441hz and 3cents off. 880A reads 882hz with 3 cents off aswell.
Each note seems to be a few cents off. I don' t know if the algorithm you
use is an approximation one but just letting you know.

On Tue, Jul 1, 2014 at 6:37 PM, Chris Wilson [email protected]
wrote:

OK, that should fix it. There was some crosstalk with further copies of
the waveform, particularly when the waveform EXACTLY matched (modulo
aliasing). Should work much better now. Also redeployed to
webaudiodemos.appspot.com.


Reply to this email directly or view it on GitHub
#5 (comment).

from pitchdetect.

cwilso avatar cwilso commented on July 23, 2024

It's actually that I'm NOT approximating, that is, I'm not coping with the
anti-aliasing. I'm playing around with a tweak that should help that by
approximating the difference, but it's still going to have errors - the
algorithm isn't perfect, and as the pitches get higher and higher you need
to approximate quite a bit. (The difference in cycle length between 880Hz
and 881Hz is 0.05 SAMPLES - so the interpolation between "best matches"
becomes quite important.)

Keep in mind we're going well into the world of analysis; you can't expect,
necessarily, that just because you're using a test oscillator you're going
to get back PRECISELY what you put into it, because this is something like
doing image analysis. The aliasing of going in to the time domain and
coming back out will cause some noise.

On Wed, Jul 2, 2014 at 7:26 AM, zcohen01 [email protected] wrote:

Im running a test oscillator through so it should be exact

On Wed, Jul 2, 2014 at 10:26 AM, Zack Cohen [email protected]
wrote:

Great! It works a ton better. Still seems to be a few cents off. 440A
reads as 441hz and 3cents off. 880A reads 882hz with 3 cents off aswell.
Each note seems to be a few cents off. I don' t know if the algorithm
you
use is an approximation one but just letting you know.

On Tue, Jul 1, 2014 at 6:37 PM, Chris Wilson [email protected]
wrote:

OK, that should fix it. There was some crosstalk with further copies of
the waveform, particularly when the waveform EXACTLY matched (modulo
aliasing). Should work much better now. Also redeployed to
webaudiodemos.appspot.com.


Reply to this email directly or view it on GitHub
#5 (comment).


Reply to this email directly or view it on GitHub
#5 (comment).

from pitchdetect.

hellofishy avatar hellofishy commented on July 23, 2024

Yeah, understandably.

Great Job! I have been playing with it a bit.

Now I am just trying to figure out how to get my audio to pick up an
acoustic guitar and not spazz out and default to F. I think it may be
picking up too much room frequency. Oh well.

Thanks for helping my understanding of tuners

On Wed, Jul 2, 2014 at 12:01 PM, Chris Wilson [email protected]
wrote:

It's actually that I'm NOT approximating, that is, I'm not coping with the
anti-aliasing. I'm playing around with a tweak that should help that by
approximating the difference, but it's still going to have errors - the
algorithm isn't perfect, and as the pitches get higher and higher you need
to approximate quite a bit. (The difference in cycle length between 880Hz
and 881Hz is 0.05 SAMPLES - so the interpolation between "best matches"
becomes quite important.)

Keep in mind we're going well into the world of analysis; you can't
expect,
necessarily, that just because you're using a test oscillator you're going
to get back PRECISELY what you put into it, because this is something like
doing image analysis. The aliasing of going in to the time domain and
coming back out will cause some noise.

On Wed, Jul 2, 2014 at 7:26 AM, zcohen01 [email protected]
wrote:

Im running a test oscillator through so it should be exact

On Wed, Jul 2, 2014 at 10:26 AM, Zack Cohen [email protected]
wrote:

Great! It works a ton better. Still seems to be a few cents off. 440A
reads as 441hz and 3cents off. 880A reads 882hz with 3 cents off
aswell.
Each note seems to be a few cents off. I don' t know if the algorithm
you
use is an approximation one but just letting you know.

On Tue, Jul 1, 2014 at 6:37 PM, Chris Wilson [email protected]

wrote:

OK, that should fix it. There was some crosstalk with further copies
of
the waveform, particularly when the waveform EXACTLY matched (modulo
aliasing). Should work much better now. Also redeployed to
webaudiodemos.appspot.com.


Reply to this email directly or view it on GitHub
#5 (comment).


Reply to this email directly or view it on GitHub
#5 (comment).


Reply to this email directly or view it on GitHub
#5 (comment).

from pitchdetect.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.