Bug when using $with properties that include belongTo relationships about eloquent-sluggable HOT 7 CLOSED

Hmm ... the solution is probably for the package to ignore the $with relationships entirely, when making that query.

I'm not at a place where I can test currently, but can you try changing that block to something like:

$results = $query->without([])
    ->select([$attribute, $this->model->getQualifiedKeyName()])
    ->get()
    ->toBase();

I'm not sure if the without([]) is the correct syntax to ignore all eager loading relations, so that might need tweaking.

Thanks!

from eloquent-sluggable.

I haven't been able to try that yet. I did see a possible withoutRelations() method for models but might not be what is needed.

Eliminating the ->select([$attribute, $this->model->getQualifiedKeyName()]) would of course solve it but I assume this is in the package to keep memory consumption down?

I'll see if I can test it tomorrow. For now, I removed my eager loading $with and it worked.

from eloquent-sluggable.

Was actually able to test it just now.

Adding ->without([]) didn't work, but using ->without(['role']) did work. Working code:

$results = $query->without(['role'])
            ->select([$attribute, $this->model->getQualifiedKeyName()])
            ->get()
            ->toBase();

Maybe there's a way to make that manageable through the array in sluggable() method that also handles the slug source?

from eloquent-sluggable.

->withoutEagerLoads() should do it, I'd think.

from eloquent-sluggable.

@cviebrock that seems to have done the trick!

As a side note: I also discovered that I only get the error when I have this turned on Model::shouldBeStrict() in my AppServiceProvider

from eloquent-sluggable.

So, I was trying to make a failing test for this before adding the fix ... but I can't seem to make one. I'm not sure if it's related to the strict mode setting you had, or something else ... but I'm not sure.

If you have some time, would you mind pulling down the issue605 branch of this package and building and testing it on your set up?

from eloquent-sluggable.

Thanks! I'll give this a try this weekend. I believe it is related to the Model::shouldBeStrict() setting. I only see it when I have the strict mode turned on. I believe that is because the MissingAttributeException exception only appears when strict mode is on - otherwise, Laravel just stays quiet when trying to access missing attributes.

from eloquent-sluggable.