Multidimensional arrays don't work about valinor HOT 2 CLOSED

Thanks for the report. @wengooooo this should be fixed with #497.

What is "weird" is needing to use the @param tag on the function phpDoc, else the mapper will recognize the array definition as array and fail. Using @var above the parameter will not work. A working example would have SomeClass defined like this.

@hollow3464 this behavior is intended, using @var works on properties, or when a constructor's parameter is also a promoted property:

// NOT OK:
final class Foo
{
    public array $values;

    public function __construct(
        /** @var array<string> */
        array $values
    ) {
        $this->values = $values;
    }
}

// OK:
final class Foo
{
    public array $values;

    /**
     * @param array<string> $values
     */
    public function __construct(
        array $values
    ) {
        $this->values = $values;
    }
}

// OK:
final class Foo
{
    public function __construct(
        /** @var array<string> */
        public array $values
    ) {}
}

from valinor.

You can only create readonly properties through a constructor.

If you remove the readonly statement it will work. It will also work if you write a constructor that does the property assignments properly.

When using a constructor, every property must me initialized or will remain uninitialized as the mapper will only use the constructor for variable assigment. Please refer to the language docs for usage on readonly props usage.

What is "weird" is needing to use the @param tag on the function phpDoc, else the mapper will recognize the array definition as array<mixed> and fail. Using @var above the parameter will not work. A working example would have SomeClass defined like this.

final class SomeClass
{
    public readonly string $description;

    /** @var array<Identifier> */
    public array $identifier;

    /**
     * @param array<Identifier> $identifier
     */
    public function __construct(
        string $description,
        array $identifier,
    ) {
        $this->description = $description;
        $this->identifier = $identifier;
    }
}

from valinor.