Humdrum metadata not appearing as music21 metadata about music21 HOT 5 CLOSED

Priority is higher for title, composer, lower for other information that m21 can handle (except for date uncertainty, etc. which would be a good test of the m21 metadata system that goes beyond MusicXML), and lowest for things that m21 can't currently handle, such as language-specific titles, etc.

from music21.

It looks to me like the problems could originate with HumdrumDataCollection.InsertGlobalEvents(). I see two issues with this function:

1. parseLines is called twice, so insertGlobalEvents is called twice. The first time, it is called before self.eventList has anything in it. Because self.eventList is empty, insertGlobalEvents can't do anything. The second time it is called, it exits immediately because the self.globalEventsInserted flag has already been set.

2. While the GlobalEvents may be correctly parsed, they are not correctly inserted into a metadata object by the insertGlobalEvents function. The problem appears to be at line 709 of spineParser.py. The correctly parsed GlobalEvents are not put into a metadata object, they are just shoved into the top level of the score.

I made some quick and gross hacks to fix the above two problems. I tested my code on the bach 371 chorales humdrum repo and it appears to read in the title correctly. With this code, only the title of the humdrum piece is properly read into the metadata, not composer or any other info. These hacks can be found in my forked copy of music21. I just added about 5 lines to insertGlobalEvents(). here is the fix for bullet point 1 here is the fix for bullet point 2

Once you can confirm with me that I'm taking the right approach, I will follow up and add the other info to the metadata.

(apologies for the messed up whitespace in my commit... my emacs is not configured right. If you decide to merge in my changes, I will fix the whitespace.)

from music21.

these look like a great approach to the problem. Thank you! Please make a fresh branch off of the master git repository with just these changes and let's start pull request merging. :-) Thanks!

from music21.

Alright, I have a pull request pending from my own fork

I gotta say, your CI system is pretty cool. I didn't know that could be integrated so smoothly with github.

from music21.

Hi John! I used your method to get most metadata parsing working from humdrum to music21. I used a slightly different approach, but I'm glad for your code ideas. It's in the commit for today.

Dates are still missing, but now it's easy to add new data. It's all in the GlobalReference object.

Thanks!

from music21.