Comments (4)
Hey, thanks for the work!
Some feedback:
- In your searches, you don't need to include
sort:updated-desc
since that's included in the query to@octokit/rest.js
. - Facebook is definitely an interesting idea, and one I'd not thought about! I really like the concept, though I think we may want to have a slightly more comprehensive description because it's an org with multiple facets 😄
from good-first-issue.
Thanks for clarifications.
- ops... about
sort:updated-desc
I did a paste & copy ofelectron
project, notnode
, shouldelectron
(andgutenberg
) be changed too? - I agree, again... had this doubt too. And what would be better? Add orgs as a whole (example:
org:facebook
and not justrepo:facebook/react
, as perorg:nodejs
) or specific repos (repo:angular/angular
, as perrepo:microsoft/vscode
, etc)?
May be could take multiple command line arguments?
good-first-issue.js angular
search in org
good-first-issue.js angular angular
search in repo (!? hard to distinguish)
good-first-issue.js react
(harder to implement?) Vs good-first-issue.js facebook react
search in repo (?!)
Edit. looks like #10 is a further step...
from good-first-issue.
Indeed, #10 has now landed.
I'd like to keep things centralized into specific commands. I'm not opposed to having unique commands for facebook
, react
, jest
, and so on.
Node.js is an org but it's a weird org in that everything in it is around Node.js as a project... so they're all basically the same project. Someone who is going to be interested in a first contribution to Node.js can contribute to any of the repos.
Facebook has multiple projects that span different technologies... someone who wants to contribute to React probably isn't interested in contributing to facebook/mysql-5.6.
Separating those concerns out and having per-project commands makes sense IMO... regardless of whether or not a project is an org or a repo. Other examples of orgs that are projects I can think of:
- Babel
- Electron (hey, there's already a command for this one!)
- webpack
- Gatsby
That said, I think it's a nifty a idea and something we should explore to have org commands like facebook
, microsoft
, github
, google
, airbnb
, and so on!
Perhaps this syntax could be used for diverse (rather than single-focus) orgs:
# Syntax
good-first-issue <org>/<repo>
# Examples
good-first-issue facebook/react
good-first-issue microsoft/azuredatastudio
good-first-issue github/gitignore
Does that make sense?
from good-first-issue.
Going to close this 👍
from good-first-issue.
Related Issues (20)
- Action required: Greenkeeper could not be activated 🚨
- Action required: Greenkeeper could not be activated 🚨
- Handle failed queries HOT 3
- Handle rate limiting HOT 4
- Action required: Greenkeeper could not be activated 🚨
- Action required: Greenkeeper could not be activated 🚨
- Use kleur instead of chalk HOT 2
- Use newline character instead of empty console.log
- Cleanup branches HOT 9
- Start script missing in package.json HOT 1
- [Documentation] Sugestion to Doc
- projects: Remove BigTestjs.io (inactive) HOT 3
- deps(boxen): error with `Docusaurus` output - emoji in title donks up output HOT 1
- [Feature Request]: onboard an ASCII flavoured banner HOT 1
- An in-range update of open is breaking the build 🚨 HOT 3
- An in-range update of commander is breaking the build 🚨 HOT 1
- An in-range update of inquirer is breaking the build 🚨 HOT 5
- Error with 'docusaurus': output issues aren't always from docusaurus HOT 2
- Octokit deprecated warning HOT 2
- Project License HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from good-first-issue.