Code Monkey home page Code Monkey logo

Comments (3)

agoldis avatar agoldis commented on July 19, 2024

Great idea! Spec level retries could be an easy win, and a more granular retries policy that is based on the error message pattern of the filter could be a more advanced feature.

Internal reference: https://www.notion.so/currents/Renderer-crash-retries-fab2e160f94c4c6f9b7d8a2c241ed502?pvs=4

from cypress-cloud.

mirobo avatar mirobo commented on July 19, 2024

Great idea on top of a great idea :-)
I mentioned this also here cypress-io/cypress#349 (comment)
But I don't think the issue in Cypress has a high priority.

It would be a good feature, not only for cypress-cloud but also for sorry-[whatever] in general (but then it would be much more difficult to implement because sorry-cypress would have to handle retries on top of Cypress retries).

But if it's done in cypress-cloud it is manageable. I guess the spec result state is stored solely on sorry-cypress instance and the test retries are handled within Cypress itself.

So before uploading the results, cypress-cloud would check the error message and check that it's only ONE attempt without any retries (so we know that cypress-cloud is not re-running a test that already had retries).

Then it would re-run the whole spec once and just use this one result (no matter if it failed again).

The only question remains if you would somehow include the first attempt or just discard it completely. I think discarding is ok, but still it would be nice to know if a certain error still occurs. So the best solution would be to add an "attempt" to the spec results object.

If the error message pattern was stored in sorry-cypress, it could later be also used for this idea sorry-cypress/sorry-cypress#761 :)

from cypress-cloud.

mwyrodek avatar mwyrodek commented on July 19, 2024

I like the idea - since cypress 1x we are seeing much more of those errors

from cypress-cloud.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.